Skip to content

Minor gui fixes#458

Open
uyraq2001 wants to merge 3 commits into
altlinux:masterfrom
uyraq2001:minor_gui_fixes
Open

Minor gui fixes#458
uyraq2001 wants to merge 3 commits into
altlinux:masterfrom
uyraq2001:minor_gui_fixes

Conversation

@uyraq2001

Copy link
Copy Markdown

No description provided.

Kozyrev Yuri added 3 commits June 17, 2026 17:30
Removed title from PSO edit widget since no other edit widget has one
and title dublicates description bar label
<bool>true</bool>
</property>
<property name="title">
<string>Password Settings</string>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to remove that label

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ConsoleWidget has a description bar so when it's enabled "Password settings" shows up twice, which seems a bit excessive. And I believe this is the reason why any other result widget has a header

<item>
<spacer name="verticalSpacer_7">
<property name="orientation">
<enum>Qt::Vertical</enum>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have that parameter and the ones below been changed due to compiler warnings?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QtCreator made this change on its own and I didn't even bother to check *.ui file change. I can remove this change or split it in another commit, but I believe QtCreator had its reasons to make these changes so we're better leave them be, and I have no idea what these reasons are thereof I can't make a good commit message for it. So I would prefer if we leave them as is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants