Fix missing benchmark comparison in GitHub step summary#1154
Merged
Conversation
tgregg
approved these changes
Jun 22, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1154 +/- ##
============================================
+ Coverage 67.23% 67.97% +0.74%
- Complexity 5484 5624 +140
============================================
Files 159 160 +1
Lines 23025 23288 +263
Branches 4126 4176 +50
============================================
+ Hits 15481 15831 +350
+ Misses 6262 6164 -98
- Partials 1282 1293 +11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Currently Detect regression step fail silently, see, e.g., #1151 , #1152, #1153. This happens because:
+emode by defaulta=$(...)lineif [ ! -z "$a" ]; then echo "${a}" >> $GITHUB_STEP_SUMMARY; exit 1; filine isn't executed.This PR is a simple fix that ensure that
a=$(...)always exits with zero code.Basic verification of
bashbehavior`By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.