Update Construct Allocs Ordering#8
Open
egc1722 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyIPCS Pull Request
Description
Fixed IRX0565E WRNG.LEN.RECORD error when running IPCS subcommands with user-provided SYSEXEC allocations. When SYSEXEC datasets with incompatible formats, FB and VB, are concatenated, REXX fails to read them if the FB format is first.
The z/OS system reads the attributes of the first dataset in the concatenation to establish the Data Control Block. If the first dataset is FB, the system expects all subsequent datasets in that concatenation to be identical in format and size. If the next dataset is VB, z/OS will fail to read it, resulting in an I/O error.
However, if the first dataset is VB then the system can handle FB files without an error.
Implementation
Reversed SYSEXEC concatenation order in
subcmd_shell.py:Changed concatenation from [pyIPCS SYSEXEC] + [User SYSEXEC] to [User SYSEXEC] + [pyIPCS SYSEXEC],
allowing VB datasets to set the concatenation format and FB datasets to be read as VB without errors.
Note that alternative solutions may include:
Related Issues
None
Were There Tests Added?
None
Code Checklist
pytest src/teststo run all tests with full success Most Important!pyproject.tomlWith Latest VersionStyle Checklist