AmbleScript ( LUA ) & JSON defined GUIs by duzos · Pull Request #59 · amblelabs/modkit

duzos · 2026-01-08T02:06:53Z

accidentally merged #58

…ove bloat

- Add core Lua infrastructure (GuiScript, GuiScriptManager, LuaBinder, LuaExpose annotation) - Add LuaElement wrapper to expose AmbleElement properties to Lua scripts - Add Minecraft API bindings (MinecraftData, MinecraftEntity, LuaItemStack) - Integrate script callbacks (onInit, onClick, onRelease, onHover) into AmbleButton - Add script property support in JSON GUI definitions - Improve AmbleText with proper text wrapping and shadow toggle - Add setDimensions helper to AmbleElement

- Rename GuiScript to AmbleScript and GuiScriptManager to ScriptManager - Move scripts from gui/script/ to script/ folder for broader use - Add ExecuteScriptCommand (/amblescript execute) to run scripts via chat - Auto-discover scripts on resource reload for command tab-completion - Add onExecute callback support for scripts triggered by command

Introduce server-side Lua scripting system parallel to client scripts: - Add ServerScriptManager for managing data pack scripts - Add ServerScriptCommand with enable/disable/execute/toggle/list commands - Refactor Lua bindings to shared script.lua package - Add ServerMinecraftData with server-specific APIs - Include example server scripts (admin_commands, tick_counter, etc.)

- enable/disable/toggle only suggest scripts with onTick method - execute only suggests scripts with onExecute method

Key improvements: - Extract AbstractScriptManager for DRY between client/server scripts - Add type-specific coercion methods to LuaBinder for clarity - Add toString methods for Vector3f, Vec3d, BlockPos in Lua - Add structured NBT access via nbt() method, deprecate nbtString() - Use IntIntImmutablePair from fastutil in AmbleElement - Add text caching in AmbleText to avoid recalculation - Add @ApiStatus.Internal and javadoc to LuaElement.unwrap() - Add init() method with javadoc to AmbleGuiRegistry - Pass resourceId to parse() for better error context - Add validation for array sizes and identifier parsing - Add FALLBACK_LAYOUT constant in AmbleContainer - Add script name logging via setScriptName/getLogPrefix - Rename ExecuteScriptCommand to ClientScriptCommand - Use Command.SINGLE_SUCCESS consistently

…actor, constants, docs

duzos · 2026-01-09T00:45:52Z

All review comments have been addressed. Changes include:

LuaElement: Added Javadoc explaining the wrapper/facade pattern
AmbleGuiRegistry: Added TODO for DatapackRegistry discussion, init() is already called from AmbleKitClient
AmbleContainer: Added TRANSPARENT constant for transparent color
AmbleText: Added clarifying comment for transient cache fields
LuaBinder: Converted to use MethodHandles for better performance
MinecraftData: Renamed getPlayer() to getExecutor() with updated docs
LuaScript: Refactored to store Globals and look up GUI callbacks on demand
ServerScriptManager: Converted onServerTick to lambda

Ready for re-review. @drtheodor

duzos · 2026-01-09T01:03:03Z

Implemented support for checking any registered keybind, not just the hardcoded movement keys.

Changes to \isKeyPressed:

Added more common shorthand names: \inventory, \drop, \chat, \pick_item, \swap_hands\
Falls back to searching all registered keybinds by their translation key
Matches both exact translation keys (e.g., \key.inventory) and suffix matches (e.g., \inventory)

New method \getKeybinds():

Returns a list of all registered keybind translation keys
Useful for scripts to discover available keybinds

This allows Lua scripts to check any keybind from vanilla Minecraft or mods.

- Support shorthand keybind names: forward, jump, inventory, sprint, etc. - Support raw keyboard keys: r, h, space, left_shift, escape, f1, etc. - Support registered keybind translation keys - Add isMouseButtonPressed for mouse button checks - Falls back through keybinds then raw keys for maximum flexibility

duzos · 2026-01-09T01:09:42Z

Updated: Merged the functionality into a single \isKeyPressed\ method that now supports:

Shorthand keybind names: \orward, \jump, \inventory, \sprint, etc.
Raw keyboard keys:
, \h, \space, \left_shift, \escape, \1, etc.
Registered keybind translation keys: \key.inventory, \key.sprint, etc.

Example usage in Lua:
\\lua
-- Check raw keys
if minecraft.isKeyPressed('r') then print('R is pressed!') end
if minecraft.isKeyPressed('space') then print('Space is pressed!') end

-- Still works with keybinds
if minecraft.isKeyPressed('jump') then print('Jump keybind pressed!') end
\\

Also added \isMouseButtonPressed()\ for mouse button checks.

- Add LUA_SCRIPTING.md with full API reference, lifecycle callbacks, and examples - Add GUI_SYSTEM.md with JSON structure docs, properties reference, and Lua integration - Update README.md with brief descriptions and links to new documentation - Fix AmbleGuiRegistry to auto-create child AmbleText when button has text property

drtheodor · 2026-01-11T19:35:18Z

+	}
+
+	@LuaExpose
+	public int x() {


This question still stands.

…commands

…nality

…ocumentation

…method for improved Lua scripting support

…t identifiers

…istency

…istency Add Testmod Client 2 configuration in build.gradle

drtheodor

yk

github-actions · 2026-07-06T06:43:53Z

no activity on this for a while - marking it S: Stale. push something or comment if its still alive, otherwise itll close in a week.

duzos added 11 commits January 7, 2026 04:54

json defined guis

6f1ab0a

woops i replaced all "json" with "registry" by accident

dc3db9d

add builders for each ui elements, add AmbleContainer#copyFrom to rem…

a4915b3

…ove bloat

remove stupid lambda

de119c1

remove LVTI

fb1d0bf

fallback msg

c605ad1

add json data to error msg so they know which block it is

34c794f

json buttons & command running buttons

62b7c7e

add LuaJ dependency for GUI scripting

9a56e17

duzos requested a review from drtheodor January 8, 2026 15:32

duzos self-assigned this Jan 8, 2026

duzos added the enhancement label Jan 8, 2026

duzos added 5 commits January 8, 2026 15:35

Expand Lua scripting API with world, player, entity, and item methods

30252ca

Add playSoundAt method to MinecraftData for Lua scripting support

4436c17

Add script lifecycle system with enable/disable/tick functionality

9a69fd1

Filter script command suggestions by available methods

853649b

- enable/disable/toggle only suggest scripts with onTick method - execute only suggests scripts with onExecute method

duzos marked this pull request as ready for review January 8, 2026 21:51

drtheodor requested changes Jan 8, 2026

View reviewed changes

drtheodor self-requested a review January 9, 2026 00:07

drtheodor requested changes Jan 9, 2026

View reviewed changes

Address PR review feedback: MethodHandles, getExecutor, LuaScript ref…

9428647

…actor, constants, docs

Fix corrupted import in AmbleButton.java

1116d63

duzos force-pushed the api/gui branch from 7f40985 to 494aa3d Compare January 9, 2026 01:09

duzos requested a review from drtheodor January 9, 2026 01:11

duzos and others added 3 commits January 9, 2026 01:29

Add skin system API, documentation, and example scripts

92f7274

Update mod_version to 1.1.16

dc58258

drtheodor requested changes Jan 11, 2026

View reviewed changes

duzos added 6 commits January 11, 2026 20:10

Add data generation support and translation keys for skin and script …

5a993ef

…commands

Add generated test files to .gitignore

82e84b7

Refactor script suggestion providers for improved clarity and functio…

74ecf73

…nality

Add cross-script function calling support and enhance Lua scripting d…

2196af3

…ocumentation

Implement AmbleElement interface in LuaElement and add findFirstText …

2d72265

…method for improved Lua scripting support

Refactor getDisplayId method to improve string manipulation for scrip…

cd69e61

…t identifiers

duzos requested a review from drtheodor January 11, 2026 20:30

duzos added 2 commits January 11, 2026 20:30

Merge remote-tracking branch 'origin/api/gui' into api/gui

105cf49

Add AmbleButton and AmbleText parsers for JSON element handling

671edfd

drtheodor requested changes Jan 11, 2026

View reviewed changes

Comment thread src/main/java/dev/amble/lib/client/command/ClientScriptCommand.java Outdated

duzos added 7 commits January 11, 2026 21:15

Add AmbleEntityDisplay component for dynamic entity rendering in GUI

50a5fec

Add AmbleTextInput component and implement focus handling in GUI

2c722ca

Refactor command return values to use Command.SINGLE_SUCCESS for cons…

760825d

…istency

fix build

17a44e4

Refactor command return values to use Command.SINGLE_SUCCESS for cons…

fe0f238

…istency Add Testmod Client 2 configuration in build.gradle

Add run2/ to .gitignore to exclude additional run directory

a12bd5c

name "testmodClient" user "Dev"

4209380

duzos requested a review from drtheodor January 11, 2026 22:33

drtheodor requested changes Jan 12, 2026

View reviewed changes

Comment thread run2/.gitkeep

duzos removed the enhancement label Jun 5, 2026

github-actions Bot added S: Stale Status: Stale with no activity, and may be closed after a week if there is no new activity. and removed S: Stale Status: Stale with no activity, and may be closed after a week if there is no new activity. labels Jul 6, 2026

Uh oh!

Uh oh!

Conversation

duzos commented Jan 8, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

duzos commented Jan 9, 2026

Uh oh!

duzos commented Jan 9, 2026

Uh oh!

duzos commented Jan 9, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

drtheodor Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

drtheodor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jul 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants