Refresh OAS baseline (Jun 2026 audit) — Etsy numeric format annotations, no SDK impact#29
Merged
Merged
Conversation
Contributor
Test Coverage ReportOverall: 100% (1672/1672 statements covered) Coverage by file
Updated by PR Tests |
There was a problem hiding this comment.
Pull request overview
This PR refreshes specs/baseline.json to match the current Etsy OpenAPI spec snapshot (Jun 2026 audit), primarily by incorporating newly added numeric format annotations (e.g., int64, a few float) so that ongoing drift checks stop flagging non-semantic spec changes.
Changes:
- Updated the OpenAPI baseline to include Etsy’s newly added numeric
formatmetadata on integer/number fields. - Adjusted JSON formatting where required (commas/ordering) to accommodate the new keys.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c35483e to
9cfc8cc
Compare
Sync specs/baseline.json with the live Etsy OAS spec. The only changes are 252 `int64` format annotations that Etsy added to integer fields. No SDK code impact: Python int is arbitrary-precision and the affected fields are already typed int. Audit result: 103/103 operations mapped, 100% effective coverage, no parameter/body drift, no missing exports, no stubs. Every audit flag was reviewed and confirmed a false positive or an already-handled deprecation (personalization fields, deprecated method aliases, country-split holiday enums, backward-compat State.REMOVED, intentional multi-line message strings). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
9cfc8cc to
8ebf9e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Full SDK audit against the live Etsy OAS spec (fetched 2026-06-02).
Result: 0 Must Fix, 0 Should Fix — the SDK is fully in sync.
The only real change since the last baseline is 252
int64formatannotations that Etsy added to integer fields (every one of the 252 additions isint64; pre-existingfloat/string formats elsewhere in the spec are unchanged). No SDK code impact — Pythonintis arbitrary-precision and the affected fields are already typedint. This PR refreshesspecs/baseline.jsonto the reviewed spec so the weekly maintenance check stops re-flagging these changes.Audit flags reviewed — all non-actionable
CA_HOLIDAYS"missing" IDs 1–105State.REMOVED"extra" vs specDeprecationWarning)createDraftListing/updateListingpersonalization fields deprecated_warn_if_personalization_usedTest plan
pytest→ 306 passed, 7 warnings (intentionalDeprecationWarnings from alias-method tests)python scripts/audit_sdk.py --spec specs/latest.json→ 100% effective coverage, no driftformatkeys (252 additions; the 25 textual deletions are trailing-comma flips, no semantic removals)Note on versioning
specs/baseline.jsonis a maintenance input, not part of the published package. To avoid a spurious patch bump + identical PyPI republish, add[skip ci]to the squash-merge commit.🤖 Generated with Claude Code