Add repeat action support to remap vol_down on newer LG Magic Remotes#30
Open
Lucaber wants to merge 1 commit into
Open
Add repeat action support to remap vol_down on newer LG Magic Remotes#30Lucaber wants to merge 1 commit into
Lucaber wants to merge 1 commit into
Conversation
This PR adds a `"repeat": true` flag so held buttons fire on key down and on each auto-repeat instead of once on release. The main motivation is to work around the long-press-to-mute behavior on newer LG Magic Remotes. Remapping vol_down with `"repeat": true` lets you hold the button to keep lowering volume instead of muting.
|
I ended up using this code to make holding my channel up/down buttons change the brightness. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
"repeat": trueflag so held buttons fire on key down and on each auto-repeat instead of once on release.The main motivation is to work around the long-press-to-mute behavior on newer LG Magic Remotes.
Remapping vol_down with
"repeat": truelets you hold the button to keep lowering volume instead of muting.