Skip to content

Compile with static version of com.google.android.gms.gni.c to fix 16…#120

Merged
natetrost merged 1 commit into
android:mainfrom
tomnomgoogleuk:patch-1
Jul 9, 2026
Merged

Compile with static version of com.google.android.gms.gni.c to fix 16…#120
natetrost merged 1 commit into
android:mainfrom
tomnomgoogleuk:patch-1

Conversation

@tomnomgoogleuk

Copy link
Copy Markdown
Contributor

…ki warning

com.google.android.gms.gni.c::gni_shared isn't 16 KiB aligned and is causing the sample to throw a warning. Statically compile the library instead to avoid this.

…ki warning

com.google.android.gms.gni.c::gni_shared isn't 16 KiB aligned and is causing the sample to throw a warning. Statically compile the library instead to avoid this.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CMakeLists.txt file for the agdktunnel app to link against the static version of the Google Play Services GNI library (gni_static) instead of the shared version (gni_shared). There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@natetrost natetrost merged commit a29d2d3 into android:main Jul 9, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants