feat: add timeout request option alongside deprecated timeout_in_seconds#271
Draft
anduril-gh-bot wants to merge 1 commit into
Draft
feat: add timeout request option alongside deprecated timeout_in_seconds#271anduril-gh-bot wants to merge 1 commit into
timeout request option alongside deprecated timeout_in_seconds#271anduril-gh-bot wants to merge 1 commit into
Conversation
…econds` Introduce a new `timeout` field (float, seconds) to RequestOptions that takes precedence over the now-deprecated `timeout_in_seconds` alias. The HTTP client resolution logic prefers `timeout` when set, falling back to `timeout_in_seconds` and then the client-level base timeout. Existing consumers using `timeout_in_seconds` remain fully backward compatible. Key changes: - Add `timeout: NotRequired[float]` field to RequestOptions - Deprecate `timeout_in_seconds` as an alias, preferring `timeout` - Update sync/async HTTP client timeout resolution to prefer `timeout`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4.19.0 → 4.20.0
Added
RequestOptions.timeout— new float field (in seconds) for setting per-request timeouts, taking precedence over the now-deprecatedtimeout_in_seconds.Changed
timeout_in_seconds— deprecated in favor oftimeout; still honored as a fallback for backward compatibility.See full changelog