build: update babel monorepo to v8#33418
Open
alan-agius4 wants to merge 1 commit into
Open
Conversation
alan-agius4
added
the
target: minor
angular-robot
Bot
added
the
area: build & ci
alan-agius4
force-pushed
the
pr-takeover-33416
branch
3 times, most recently
from
60f3f95 to
2ede90f
Compare
alan-agius4
added
the
action: review
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request upgrades Babel dependencies to version 8 across the workspace, updating type imports (such as using 'PluginObject' instead of 'PluginObj') and removing deprecated configuration options like 'bugfixes' and 'useESModules'. The feedback highlights a critical compatibility issue with Babel 8: raw object plugins are no longer supported and will cause runtime crashes. Instead of using unsafe type assertions, the reviewer recommends wrapping these plugin objects in factory functions (arrow functions) to ensure compatibility and type safety.
See associated pull request for more information. Closes angular#33416 as a pr takeover
alan-agius4
force-pushed
the
pr-takeover-33416
branch
from
2ede90f to
cd7ee37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See associated pull request for more information.
Closes #33416 as a pr takeover