feat(contract): introduce multi-sig and timelock support for critical admin actions (#932) - #1
Open
anthonia01-dev wants to merge 2 commits into
Open
Conversation
… admin actions Adds a new AdminActionProposal flow so that sensitive platform operations require multi-sig approval and a timelock before execution. Changes: - Add AdminActionKind, AdminActionProposal, AdminActionDataKey types - Add error variants: AdminActionTerminal, AdminActionNeedsApprovals, AdminActionTimelockActive, NotAnAdminActionSigner - Add configuration: set_admin_action_signers, set_admin_action_threshold, set_admin_action_timelock_delay - Add core flow: propose_admin_action, approve_admin_action, cancel_admin_action, execute_admin_action, get_pending_admin_actions - Add apply_admin_action handler covering: PausePlatform, SetPlatformFee, SetPlatformWallet, SetWasmUpgradeCooldown, SetMinStakeRequired, SweepUnallocatedFunds, ExecuteUpgrade, SetMaxDisputeDuration, SetStakeCooldown, SetArtisanFeeTier, SetModerator, SetMinEscrowAmount, SetMaxReleaseWindow, SetMinReleaseWindow, SetOnboardingContract, SetExpiredDisputePolicy - Add set_paused_internal helper for timelock-compatible pause toggling - Add comprehensive tests covering signer auth, threshold enforcement, timelock blocking, execution after delay, cancellation, double approval, pending action enumeration, and new governance action variants Closes Hub-of-Evolution#932
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces a Multi-Signature and Timelock workflow for all critical admin actions on the CraftNexus contract. High-risk operations (pausing, sweeping, upgrades, and governance parameter changes) can no longer execute with a single admin signature; they now require configured signer approvals and must survive a timelock before execution.
Acceptance Criteria
Key Changes
New Types
AdminActionKind— enum covering all critical actionsAdminActionProposal— persistent proposal recordAdminActionDataKey— storage keys for the proposal systemNew Errors
AdminActionTerminalAdminActionNeedsApprovalsAdminActionTimelockActiveNotAnAdminActionSignerNew Public API
set_admin_action_signers,set_admin_action_threshold,set_admin_action_timelock_delaypropose_admin_action,approve_admin_action,cancel_admin_action,execute_admin_action,get_pending_admin_actionsSecurity Properties
Closes Hub-of-Evolution#932