Skip to content

Add annualized rate to vault share price chart #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
starksama wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add annualized rate to vault share price chart #605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions src/features/vault/components/vault-share-price-chart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,13 @@ import { TableContainerWithDescription } from '@/components/common/table-contain
import { Select, SelectContent, SelectItem, SelectTrigger, SelectValue } from '@/components/ui/select';
import { Spinner } from '@/components/ui/spinner';
import { useChartColors } from '@/constants/chartColors';
import { useRateLabel } from '@/hooks/useRateLabel';
import { useVaultSharePriceHistory } from '@/hooks/useVaultSharePriceHistory';
import { useAppSettings } from '@/stores/useAppSettings';
import { type ChartTimeframe, useMarketDetailChartState } from '@/stores/useMarketDetailChartState';
import { formatChartTime } from '@/utils/chart';
import type { SupportedNetworks } from '@/utils/networks';
import { computeAnnualizedApyFromValueGrowth, formatRateAsPercentage, toDisplayRateFromApy } from '@/utils/rateMath';
import {
ChartGradients,
ChartTooltipContent,
Expand Down Expand Up @@ -81,6 +84,15 @@ function formatChangePercent(value: number | null): string {
return `${value >= 0 ? '+' : ''}${value.toFixed(4)}%`;
}

function formatAnnualizedRate(annualizedApy: number | null, isAprDisplay: boolean): string {
if (annualizedApy === null || !Number.isFinite(annualizedApy)) {
return '--';
}

const displayRate = toDisplayRateFromApy(annualizedApy, isAprDisplay);
return formatRateAsPercentage(displayRate, 4);
}

function changeTextColor(value: number | null): string {
if (value === null) {
return 'text-secondary';
Expand All @@ -99,6 +111,8 @@ export function VaultSharePriceChart({
const selectedTimeframe = useMarketDetailChartState((state) => state.selectedTimeframe);
const selectedTimeRange = useMarketDetailChartState((state) => state.selectedTimeRange);
const setTimeframe = useMarketDetailChartState((state) => state.setTimeframe);
const { isAprDisplay } = useAppSettings();
const { short: rateLabel } = useRateLabel();
const chartColors = useChartColors();

const { data, isError, isFetching, isLoading } = useVaultSharePriceHistory({
Expand Down Expand Up @@ -141,6 +155,15 @@ export function VaultSharePriceChart({
firstPoint && lastPoint && firstPoint.sharePrice > 0
? ((lastPoint.sharePrice - firstPoint.sharePrice) / firstPoint.sharePrice) * 100
: null;
const periodSeconds = firstPoint && lastPoint ? lastPoint.x - firstPoint.x : 0;
const annualizedApy =
firstPoint && lastPoint
? computeAnnualizedApyFromValueGrowth({
currentValue: lastPoint.sharePrice,
pastValue: firstPoint.sharePrice,
periodSeconds,
})
: null;
const yAxisDomain = useMemo(() => getSharePriceDomain(chartData, selectedTimeframe), [chartData, selectedTimeframe]);
const isInitialLoading = isLoading;
const isUnavailable = data?.isUnsupportedNetwork || isError || (!isInitialLoading && chartData.length < 2);
Expand Down Expand Up @@ -189,6 +212,10 @@ export function VaultSharePriceChart({
<p className="text-xs uppercase tracking-wider text-secondary">{TIMEFRAME_LABELS[selectedTimeframe]} Change</p>
<p className={`tabular-nums text-lg ${changeTextColor(changePercent)}`}>{formatChangePercent(changePercent)}</p>
</div>
<div>
<p className="text-xs uppercase tracking-wider text-secondary">Annualized {rateLabel}</p>
<p className={`tabular-nums text-lg ${changeTextColor(annualizedApy)}`}>{formatAnnualizedRate(annualizedApy, isAprDisplay)}</p>
</div>
</div>
</div>

Expand Down