Skip to content

Feature/8387 search with acronyms subfield and autocomplete#283

Merged
utas-raymondng merged 8 commits into
mainfrom
feature/8387-search-with-acronyms-subfield-and-autocomplete
Jun 26, 2026
Merged

Feature/8387 search with acronyms subfield and autocomplete#283
utas-raymondng merged 8 commits into
mainfrom
feature/8387-search-with-acronyms-subfield-and-autocomplete

Conversation

@utas-amberbian

@utas-amberbian utas-amberbian commented Jun 16, 2026

Copy link
Copy Markdown
Contributor
Screenshot from 2026-06-17 11-39-57 Screenshot from 2026-06-17 11-40-10

@utas-amberbian utas-amberbian marked this pull request as draft June 16, 2026 07:18
@utas-amberbian utas-amberbian force-pushed the feature/8387-search-with-acronyms-subfield-and-autocomplete branch from cadf487 to ec1660f Compare June 17, 2026 00:13
@utas-amberbian utas-amberbian marked this pull request as ready for review June 17, 2026 01:31

@utas-raymondng utas-raymondng left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally good, except the hardcode schema, please wait for the es-index update and tag before proceed

@utas-amberbian utas-amberbian marked this pull request as draft June 18, 2026 01:19

@utas-raymondng utas-raymondng left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets wait till the es-indexer version tag and you updated the ogc api before PR this

@utas-raymondng

utas-raymondng commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator

@utas-amberbian https://github.com/aodn/es-indexer/releases tagged and please load the schema file that contains your acronym change via the JsonUtils in stacmodel

@utas-amberbian

Copy link
Copy Markdown
Contributor Author

Hi @utas-raymondng,

I've updated the test case. Before we merge to the edge branch, we need @atkinsn to confirm the acronym, so I'll keep this as a draft for now. Thanks.

@utas-raymondng

Copy link
Copy Markdown
Collaborator

So nat know you are waiting for her?

@utas-amberbian

Copy link
Copy Markdown
Contributor Author

So nat know you are waiting for her?

Yes, she knows.

@utas-raymondng

Copy link
Copy Markdown
Collaborator

Thanks, is this a hard deps or we can update the mapping with another ticket?

@utas-amberbian

Copy link
Copy Markdown
Contributor Author

Thanks, is this a hard deps or we can update the mapping with another ticket?

This is a hard dependency for the acronyms autocomplete. Mapping means the acronyms list? You mean we can manually empty them in the cloud and codebase for now?

@utas-amberbian utas-amberbian marked this pull request as ready for review June 25, 2026 07:27

@utas-raymondng utas-raymondng left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@utas-raymondng utas-raymondng merged commit bb1cb55 into main Jun 26, 2026
4 checks passed
@utas-raymondng utas-raymondng deleted the feature/8387-search-with-acronyms-subfield-and-autocomplete branch June 26, 2026 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants