Skip to content

change duringImpl logic to adapt overlapped date range#288

Merged
utas-raymondng merged 7 commits into
mainfrom
bugfix/8621-fix-date-range-query
Jun 26, 2026
Merged

change duringImpl logic to adapt overlapped date range#288
utas-raymondng merged 7 commits into
mainfrom
bugfix/8621-fix-date-range-query

Conversation

@shaunahu

@shaunahu shaunahu commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

This PR fixes temporal DURING filtering so collection date ranges are matched by overlap rather than by requiring the record start/end to sit inside the query bounds.

Changes

  • Updates DuringImpl to match records where temporal.start <= filterEnd and temporal.end >= filterStart.
  • Includes ongoing records with no temporal.end when their start date overlaps the requested range.
  • Updates REST API datetime tests to reflect the corrected range-overlap behaviour.
  • Changes credit_contains from a match query to a match_phrase query for more precise credit field matching.
image

@shaunahu shaunahu marked this pull request as ready for review June 26, 2026 05:25

@utas-raymondng utas-raymondng left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@utas-raymondng utas-raymondng merged commit 11d0677 into main Jun 26, 2026
4 checks passed
@utas-raymondng utas-raymondng deleted the bugfix/8621-fix-date-range-query branch June 26, 2026 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants