Removing Custom...Server.java classes and replacing with Thrift implementation#6454
Open
Amemeda wants to merge 7 commits into
Open
Removing Custom...Server.java classes and replacing with Thrift implementation#6454Amemeda wants to merge 7 commits into
Amemeda wants to merge 7 commits into
Conversation
Contributor
Author
dlmarion
reviewed
Jul 9, 2026
| } | ||
|
|
||
| return new ServerAddress(new CustomNonBlockingServer(options), address); | ||
| CustomNonBlockingServer server = new CustomNonBlockingServer(options); |
Contributor
There was a problem hiding this comment.
It appears the CustomNonBlockingServer is also custom solely to get the client address. We might be able to remove this as well.
Contributor
Author
There was a problem hiding this comment.
Ive removed that one, I think that's all the custom server classes. The only remaining custom classes I see are CustomObjectMapper and CustomHsHaNestedIT
Amemeda
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Investigated relevance of CustomThreadedSelectorServer.java
return new ServerAddress(new CustomThreadedSelectorServer(options), address);Result:
setServerEventHandler(new ThriftServerEventHandler());to applicable tservers