Skip to content

Remove externalTrafficPolicy from template for service type ClusterIP#950

Open
birke-kb wants to merge 1 commit into
apache:masterfrom
birke-kb:fix/service-type-cluster-ip
Open

Remove externalTrafficPolicy from template for service type ClusterIP#950
birke-kb wants to merge 1 commit into
apache:masterfrom
birke-kb:fix/service-type-cluster-ip

Conversation

@birke-kb

Copy link
Copy Markdown

Add a condition to specify externalTrafficPolicy in the apisix-gateway service spec only for service types LoadBalancer and NodePort. Adding the field for service type ClusterIP leads to configuration errors in Kubernetes.

@eedeebee

Copy link
Copy Markdown

Hi apisix folks - thanks for making and maintaining this chart!

Is there anything else needed for this PR to get reviewed?

It addresses #755 and #780 which have been open for 2 years. I'm happy to help or add whatever it takes to get it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

question Further information is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants