chore: allow L4 upstream schemes (tcp/tls/udp) in ingress-controller CRDs - #992
Open
AlinsRan wants to merge 1 commit into
Open
chore: allow L4 upstream schemes (tcp/tls/udp) in ingress-controller CRDs#992AlinsRan wants to merge 1 commit into
AlinsRan wants to merge 1 commit into
Conversation
…CRDs APISIX accepts `tcp`, `tls` and `udp` as upstream schemes for L4 proxying, and `scheme: tls` is what makes the gateway establish the TLS session with a stream upstream. The bundled CRDs still restricted `ApisixUpstream.spec.scheme` and `BackendTrafficPolicy.spec.scheme` to the L7 set, so the API server rejected those values before the controller could see them. Syncs the scheme field of charts/apisix-ingress-controller/crds/apisixic-crds.yaml with apache/apisix-ingress-controller#2830.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pairs with apache/apisix-ingress-controller#2830 (fixes apache/apisix-ingress-controller#2803).
APISIX accepts
tcp,tlsandudpas upstream schemes for L4 proxying, andscheme: tlsis what makes the gateway establish the TLS session with a stream upstream (plain TCP in from the client, TLS out to the backend). The CRDs bundled in this chart still restrictApisixUpstream.spec.schemeandBackendTrafficPolicy.spec.schemeto the L7 set, so on a standard Helm installation the API server rejectstcp/tls/udpbefore the controller ever sees the resource.This updates the three
schemefields incharts/apisix-ingress-controller/crds/apisixic-crds.yaml(top-level andportLevelSettingsof ApisixUpstream, plus BackendTrafficPolicy) to match whatmake helm-build-crdsproduces from apache/apisix-ingress-controller#2830.Only the
schemeblocks are touched; the rest of the bundle is left as-is and will be refreshed by the next release bump.