Bump org.postgresql:postgresql from 42.4.4 to 42.7.11 in /contrib/storage-jdbc#3048
Conversation
|
@dependabot rebase |
Bumps [org.postgresql:postgresql](https://github.com/pgjdbc/pgjdbc) from 42.4.4 to 42.7.11. - [Release notes](https://github.com/pgjdbc/pgjdbc/releases) - [Changelog](https://github.com/pgjdbc/pgjdbc/blob/master/CHANGELOG.md) - [Commits](pgjdbc/pgjdbc@REL42.4.4...REL42.7.11) --- updated-dependencies: - dependency-name: org.postgresql:postgresql dependency-version: 42.7.11 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
caf5255 to
d26b96e
Compare
|
I pushed a follow-up commit ( Why the bump alone failed: with 42.4.4 the Postgres tests pass, but bumping to 42.7.11 broke every Postgres storage test with Root cause: a
Fix: capture the connection's own database via (Heads-up: since this PR now carries a manual commit, Dependabot will stop rebasing it.) |
The PostgreSQL JDBC driver 42.7+ reports the connection's own database as the
TABLE_CATALOG for DatabaseMetaData.getSchemas(), whereas 42.4.x reported null.
JdbcCatalogSchema used that catalog value to nest schemas under their catalog,
so "pg.public" silently became "pg.<database>.public". This broke every Postgres
storage test ("Schema [pg.public] is not valid") and would have changed the
schema paths existing Drill users query.
When the driver reports catalogs other than the connection's own (as servers
like PostgreSQL do, listing sibling databases a single connection cannot query
across), register the connection's own catalog's schemas at the plugin top level
rather than nested under the catalog. This restores the pre-42.7 paths without
any dialect-specific code. Single-catalog sources such as H2 keep their existing
catalog nesting, so "h2.tmp.drill_h2_test" is unaffected.
5552acb to
898a519
Compare
|
Revised the follow-up commit to avoid dialect-specific code and to fix an H2 regression my first attempt introduced. What was wrong with the first attempt: flattening any schema whose General rule used instead (no per-dialect branching): a JDBC connection is bound to a single catalog. If Verification (local):
|
Bumps org.postgresql:postgresql from 42.4.4 to 42.7.11.
Release notes
Sourced from org.postgresql:postgresql's releases.
... (truncated)
Changelog
Sourced from org.postgresql:postgresql's changelog.
... (truncated)
Commits
78e261ffix: Add sources and javadocs to shaded published lib generation1e09fa0update Changelog and website for release of 42.7.11 (#4042)d479fa5Fix scram fix location in changelog and update published artifact developer l...b04fc46docs: Add scram max iters fix to changelogcf54822test: Disable scram test on older version without scram_iterations GUC7dbcc79test: Add SCRAM max iteration testsc9d41d1fix: Limit SCRAM PBKDF2 iterations accepted from the servera340cb2style: replace@exceptionwith@throwsin getBoolean javadoc77837f8fix(deps): update dependency org.openrewrite.rewrite:org.openrewrite.rewrite....23af03bchore(deps): update actions/checkout action to v6