Skip to content

FELIX-6853 adding ability to inspect preprocessors when in debug mode #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pat-lego wants to merge 2 commits into
base: master
Choose a base branch
from
+12 −0
Open

FELIX-6853 adding ability to inspect preprocessors when in debug mode #540

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f2e0b9
FELIX-6853 adding ability to inspect preprocessors when in debug mode
Jul 31, 2026
c4fe993
FELIX-6853 fixing whitespace
Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions http/base/src/main/java/org/apache/felix/http/base/internal/handler/PreprocessorHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

import org.apache.felix.http.base.internal.logger.SystemLogger;
import org.apache.felix.http.base.internal.runtime.PreprocessorInfo;
import org.apache.felix.http.base.internal.wrappers.PreprocessorWrapper;
import org.jetbrains.annotations.NotNull;
import org.osgi.framework.BundleContext;
import org.osgi.service.servlet.runtime.dto.DTOConstants;
Expand All @@ -30,6 +31,7 @@
import jakarta.servlet.ServletException;
import jakarta.servlet.ServletRequest;
import jakarta.servlet.ServletResponse;
import jakarta.servlet.http.HttpServletRequest;

/**
* The preprocessor handler handles the initialization and destruction of preprocessor
Expand Down Expand Up @@ -129,6 +131,16 @@ public void handle(@NotNull final ServletRequest req,
final Preprocessor local = this.preprocessor;
if ( local != null )
{
if (SystemLogger.LOGGER.isDebugEnabled()) {
HttpServletRequest hRequest = (HttpServletRequest) req;
if (local instanceof org.apache.felix.http.base.internal.wrappers.PreprocessorWrapper) {
PreprocessorWrapper tmpLocal = (org.apache.felix.http.base.internal.wrappers.PreprocessorWrapper) local;
SystemLogger.LOGGER.debug("Invoking OSGi preprocessor {} for path {}", tmpLocal.getPreprocessor().getClass().getName(), hRequest.getRequestURI());
} else {
SystemLogger.LOGGER.debug("Invoking OSGi preprocessor {} for path {}", local.getClass().getName(), hRequest.getRequestURI());
}

}
local.doFilter(req, res, chain);
}
else
Expand Down