[rust] Add version-aware integration test harness (0.9.x / 1.x)#632
Open
gnuhpc wants to merge 4 commits into
Open
[rust] Add version-aware integration test harness (0.9.x / 1.x)#632gnuhpc wants to merge 4 commits into
gnuhpc wants to merge 4 commits into
Conversation
gnuhpc
force-pushed
the
pr/5-integration-tests
branch
from
5b2ce66 to
003548f
Compare
Contributor
Author
|
Rebased on top of updated #631. Test fixtures migrated from Verified against real Java Fluss 0.9.1-incubating (68/68 tests pass without |
gnuhpc
force-pushed
the
pr/5-integration-tests
branch
from
003548f to
5b79a57
Compare
Contributor
Author
|
Updated integration tests to use domain enums ( |
gnuhpc
force-pushed
the
pr/5-integration-tests
branch
3 times, most recently
from
fdb66ef to
6a808db
Compare
Member
|
@gnuhpc Can you,pls, rebase/cherry pick against current main, so I can review? |
- Replace raw SERVER_TAG_TEMPORARY_OFFLINE const with ServerTag::TemporaryOffline - Add readable parameter to get_lake_snapshot call Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Pass `None` for the new `comment` parameter to keep round-2 reviewer-fix commits self-contained on each PR branch. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
After round 2's ClusterHealthStatus enum change, the variant is already validated by try_from_i32 on deserialisation, making the `>= 0` check redundant. Removing it also fixes a fluss_v1-feature-only compile error (comparing enum with integer). The remaining `.expect()` still proves the call succeeded. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
gnuhpc
force-pushed
the
pr/5-integration-tests
branch
from
7f0445c to
d1d08f5
Compare
Contributor
Author
|
Rebased onto main. Should be clean for review now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an integration-test harness and tests for the 1.x admin surface:
Cargo.toml:integration_tests+fluss_v1feature flags (the latter gates tests exercising APIs only on 1.x servers).admin_extended.rs: end-to-end tests for the extended admin methods (ACLs, cluster configs, rebalance, server tags, producer offsets, KV snapshots, table stats).admin_v1.rs: tests for the 1.x-only RPCs.test_fluss.rs: wires the new test modules.Tests tolerate
UnsupportedVersionso the same suite runs green against both 0.9.x and 1.x server images.Stack
Part 5/6, stacked on #631 → #630 → #629 → #628. All target
main.🤖 Generated with Claude Code