Skip to content

HADOOP-19930. ObjectWritable to validate class on load#8569

Open
steveloughran wants to merge 1 commit into
apache:trunkfrom
steveloughran:pr/HADOOP-19864-writable-load
Open

HADOOP-19930. ObjectWritable to validate class on load#8569
steveloughran wants to merge 1 commit into
apache:trunkfrom
steveloughran:pr/HADOOP-19864-writable-load

Conversation

@steveloughran

@steveloughran steveloughran commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Pulls up class type checking to before actual class load; fails faster.
-Add check of array length.
-Limit recursive depth to 100.

Choice of depth is completely random; FWIW jackson has a limit of 1000.

How was this patch tested?

New tests

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

AI Tooling

If an AI tool was used:

@steveloughran steveloughran force-pushed the pr/HADOOP-19864-writable-load branch from 9cd5316 to ecdaf1c Compare June 29, 2026 13:41
@steveloughran steveloughran changed the title HADOOP-19864. Writable to validate class on load HADOOP-19930. ObjectWritable to validate class on load Jun 29, 2026
@hadoop-yetus

Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ patch 0m 22s #8569 does not apply to trunk. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.
Subsystem Report/Notes
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8569/3/console
versions git=2.34.1
Powered by Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

@steveloughran steveloughran force-pushed the pr/HADOOP-19864-writable-load branch from d801691 to 2513bb6 Compare June 29, 2026 16:41
@github-actions github-actions Bot added the TOOLS label Jun 29, 2026
@apache apache deleted a comment from hadoop-yetus Jul 9, 2026
New reflection validation in ReflectionUtils
-Pulls up class type checking to before actual class load; fails fast
-Add check of array length.
-Limit recursive depth to 100.

Contains content generated by Claude.ai

Contributed by Steve Loughran.
@steveloughran steveloughran force-pushed the pr/HADOOP-19864-writable-load branch from fea4ff2 to 9861bbb Compare July 9, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants