HADOOP-19935. Windows: make preferIPv4Stack overridable, matching hadoop-functions.sh#8592
Open
smengcl wants to merge 1 commit into
Open
HADOOP-19935. Windows: make preferIPv4Stack overridable, matching hadoop-functions.sh#8592smengcl wants to merge 1 commit into
smengcl wants to merge 1 commit into
Conversation
…oop-functions.sh.
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
💔 -1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Prompted by HADOOP-16943, I noticed that Windows hadoop-config.cmd still disables IPv6.
On Unix the IPv4 pin has been overridable since HADOOP-9902: hadoop-functions.sh uses
${HADOOP_OPTS:-"-Djava.net.preferIPv4Stack=true"}, so setting HADOOP_OPTS selects dual-stack or IPv6. hadoop-config.cmd never matched it. It appended the pin unconditionally, so IPv6 could not be enabled on Windows at all.Apply the pin only when HADOOP_OPTS is unset, mirroring the Unix default. IPv4 stays the default when HADOOP_OPTS is unset; operators who set it can now choose dual-stack or IPv6.
How was this patch tested?
n/a. There's no Windows CI.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?AI Tooling
If an AI tool was used:
where is the name of the AI tool used.
https://www.apache.org/legal/generative-tooling.html