Add plexus GitHub - #49
Conversation
as it is used in Plexus project and therefore nice to have it at hand when working on GH workflows.
Addresses Hervé Boutemy's review on apache#21: use a visible directory name for the local checkout instead of the hidden `.github`. The remote repository name (`.github.git`) is unchanged; only the `path` in the manifest and the README directory tree are updated.
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Adds the Codehaus Plexus shared GitHub workflows repository (.github) to the repo manifest so it can be checked out alongside other Plexus projects.
Changes:
- Add the
.githubrepository todefault.xmlwith a local checkout path ofplexus/github - Update
README.md’s example directory tree to include the newplexus/githubfolder
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| default.xml | Adds a new manifest <project> entry for the shared .github repository |
| README.md | Updates the documented resulting directory structure to reflect the new checkout |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <project path='svn/doxia-ide' name='maven-doxia-ide.git' revision='trunk' /> | ||
|
|
||
| <project path='plexus/codehaus-plexus.github.io' name='codehaus-plexus.github.io.git' remote='plexus' revision='source' /> | ||
| <project path='plexus/github' name='.github.git' remote='plexus' /> |
There was a problem hiding this comment.
Thanks, but this is intentional. Omitting revision is the norm in this manifest, not the exception: 107 of 135 entries (and 17 of the 18 plexus/* entries) carry no revision and deliberately track the remote's default branch. The single plexus/* entry that pins one — codehaus-plexus.github.io with revision='source' — does so precisely because its content lives on a non-default branch.
codehaus-plexus/.github is tracked on its default branch (master), so omitting revision here is the consistent and correct choice; adding one would make this entry the odd one out. Keeping it as-is.
Adds the Codehaus Plexus shared
.githubrepository to the manifest, asit is used across Plexus projects and handy to have at hand when working
on GH workflows.
This supersedes #21, which was raised from a fork I no longer have write
access to and could therefore no longer be updated. The branch has been
rebased onto the current
master.It also addresses @hboutemy's review on #21: the local checkout path uses
the visible name
githubinstead of the hidden.github(commit43cd665). The remote repository name (
.github.git) is unchanged.