GH-909: Fix KexOutputHandler self-deadlock on inline write failure during shutdown#910
Open
zimmermq wants to merge 1 commit into
Open
GH-909: Fix KexOutputHandler self-deadlock on inline write failure during shutdown#910zimmermq wants to merge 1 commit into
zimmermq wants to merge 1 commit into
Conversation
…adlock on inline write failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #909.
When a write started under the read lock in
writeOrEnqueue()fails inline, the session close re-enters KexOutputHandler.shutdown()→updateState()`, which tries to take the write lock on the same thread — an illegal read-to-write upgrade that self-deadlocks.Fix: in
shutdown(), when the current thread already holds the read lock (getReadHoldCount() > 0), update the state without acquiring the write lock. The read lock already excludes writers, so it stays consistent; KEX write-ordering is unchanged.Includes a deterministic regression test (hangs without the fix, passes with it).