GH-3618: Upgrade JUnit4 to JUnit 5.14.4#3619
Open
nastra wants to merge 1 commit into
Open
Conversation
nastra
commented
Jun 19, 2026
| </dependency> | ||
| <dependency> | ||
| <groupId>org.junit.vintage</groupId> | ||
| <artifactId>junit-vintage-engine</artifactId> |
Contributor
Author
There was a problem hiding this comment.
the vintage engine runs JUnit4 tests while the jupiter engine runs JUnit5 tests. Having both dependencies allows for easier and gradual migrations of JUnit4 -> JUnit5 test code
nastra
commented
Jun 19, 2026
| <ignoreNonCompile>true</ignoreNonCompile> | ||
| <ignoredDependencies> | ||
| <dependency>javax.annotation:javax.annotation-api:jar:1.3.2</dependency> | ||
| <dependency>junit:junit</dependency> |
Contributor
Author
There was a problem hiding this comment.
this now comes in transitively from junit-vintage-engine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
JUnit4 is outdated and the last release was in 2021. This switches to JUnit5 in order to make it possible to migrate the existing tests from JUnit4 to JUnit5 in the scope of #3618
What changes are included in this PR?
Are these changes tested?
existing tests
Are there any user-facing changes?
/cc @Fokko @wgtmac