Migrates container create, run-lifecycle, exec, remove, copy.#1844
Merged
Conversation
jglogan
changed the title
Code Coverage
|
jglogan
changed the title
jglogan
force-pushed
the
testmigrate-group4
branch
from
0ff39ee to
ba3ef5d
Compare
jglogan
changed the title
jglogan
force-pushed
the
testmigrate-group4
branch
5 times, most recently
from
1611374 to
a9f18e8
Compare
jglogan
force-pushed
the
testmigrate-group4
branch
from
a9f18e8 to
7401107
Compare
katiewasnothere
approved these changes
Jul 1, 2026
katiewasnothere
left a comment
katiewasnothere
left a comment
Contributor
There was a problem hiding this comment.
A couple comments but LGTM and can be done in a later PR
|
|
||
| @Test func testStartIdempotent() async throws { | ||
| try await ContainerFixture.with { f in | ||
| let image = try f.copyWarmupImage(ContainerFixture.warmupImages[0]) |
Contributor
There was a problem hiding this comment.
Images are being copied here unnecessarily
| /// Serial prune tests — `container prune` affects all stopped containers regardless of name. | ||
| @Suite(.serialized) | ||
| struct TestCLIPruneCommandSerial { | ||
| @Test(.disabled("flaky — prune picks up containers from concurrent suites; tests being rewritten")) |
Contributor
There was a problem hiding this comment.
Is this ready to be re-enabled?
Contributor
Author
There was a problem hiding this comment.
Good catch...I'll see if we can reenable in the final PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
More reliable integration tests.
Testing