Fix mv self-move failure on Linux in TeX build path - #8
Open
alcarraz wants to merge 1 commit into
Open
Conversation
GNU mv refuses to move a file onto itself, but PDF is always
"${BASENAME}.pdf", so the mv after the TeX pass was always a no-op
move that errored out on Linux. Pandoc already writes the PDF to
that path directly, so the mv is unnecessary; remove it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PDF is always "${BASENAME}.pdf", assigned in line 170.
On macOS, the move is a no-op, but it fails on Linux, this fix just removes the
mvcommand.Another fix could be to do nothing if the files are the same, but it would be a check that is always true, unless it is there for when/if we want to pass the PDF write route as an argument.
Test plan