fix: add Askr static analysis script - #22
Merged
Merged
Conversation
Contributor
Author
|
/copilot review |
There was a problem hiding this comment.
Pull request overview
This PR introduces a new npm run analyze command backed by the pinned Askr CLI, and updates the docs search component to use lifecycle-scoped keyboard handling and keyed list reconciliation while remaining SSR-safe.
Changes:
- Add
npm run analyze(askr analyze --check) for read-only static analysis verification. - Make the docs search keyboard listener lifecycle-scoped with a render-order-stable
on(...)setup that avoids SSRwindowaccess. - Render docs search results with keyed
<For>reconciliation for stable updates.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/pages/docs/search.tsx | Uses lifecycle-scoped on(...) for keyboard shortcuts and switches search results rendering to keyed <For> reconciliation. |
| package.json | Adds analyze script invoking askr analyze --check. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm run analyzeproject command backed by the pinned Askr CLI<For>reconciliationVerification
npm run analyze(44 source files; 0 errors, warnings, or info before build)npm run typechecknpm run checknpm audit --audit-level=highThe current CLI also reports generated
.askr/client/assetsallocations as informational findings after a build; those do not fail the command and are not source diagnostics.