Skip to content

fix: add Askr static analysis script - #22

Merged
smiggleworth merged 1 commit into
mainfrom
fix/add-analyze-script
Jul 27, 2026
Merged

fix: add Askr static analysis script#22
smiggleworth merged 1 commit into
mainfrom
fix/add-analyze-script

Conversation

@smiggleworth

Copy link
Copy Markdown
Contributor

Summary

  • add a read-only npm run analyze project command backed by the pinned Askr CLI
  • make the docs search keyboard listener render-order stable while remaining SSR-safe
  • render reactive search results with keyed <For> reconciliation

Verification

  • npm run analyze (44 source files; 0 errors, warnings, or info before build)
  • npm run typecheck
  • npm run check
  • npm audit --audit-level=high
  • production SSG: 338/338 routes, 0 failures
  • static verification: 338 routes, 32,501 API anchors

The current CLI also reports generated .askr/client/assets allocations as informational findings after a build; those do not fail the command and are not source diagnostics.

Copilot AI review requested due to automatic review settings July 27, 2026 13:36
@smiggleworth

Copy link
Copy Markdown
Contributor Author

/copilot review

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new npm run analyze command backed by the pinned Askr CLI, and updates the docs search component to use lifecycle-scoped keyboard handling and keyed list reconciliation while remaining SSR-safe.

Changes:

  • Add npm run analyze (askr analyze --check) for read-only static analysis verification.
  • Make the docs search keyboard listener lifecycle-scoped with a render-order-stable on(...) setup that avoids SSR window access.
  • Render docs search results with keyed <For> reconciliation for stable updates.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/pages/docs/search.tsx Uses lifecycle-scoped on(...) for keyboard shortcuts and switches search results rendering to keyed <For> reconciliation.
package.json Adds analyze script invoking askr analyze --check.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@smiggleworth
smiggleworth merged commit 5506b04 into main Jul 27, 2026
2 checks passed
@smiggleworth
smiggleworth deleted the fix/add-analyze-script branch July 27, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants