fix: refresh website dependencies and analyzer-safe rendering - #23
Merged
Conversation
Fact-checked marketing and docs copy against the installed @askrjs/* packages. Fixed the OIDC exchangeCode() example to match the real OidcCodeExchange shape, corrected the OpenTelemetry claim from "redaction-aware" to allowlist-based (the actual mechanism), and removed the platform page's benchmark table since the numbers had no supporting methodology or reproducible source in the repo. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the website’s dependency set and refreshes generated docs snapshots, while also migrating route/docs rendering patterns toward analyzer-safe primitives (<For>, <Show>) to improve correctness under Askr’s rendering model.
Changes:
- Bumped
@askrjspackages (and related tooling) and regenerated lockfile + docs snapshots (API manifest, CLI snapshot, package versions). - Replaced multiple
.map()render loops and ternaries with<For>/<Show>to align with analyzer-safe rendering patterns. - Updated/selectively removed marketing/docs content (e.g., benchmark snapshot removal, production copy tweaks) and adjusted docs navigation/search behaviors.
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/pages/site-footer.tsx | Switch footer link lists to <For> for keyed rendering. |
| src/pages/marketing/production.tsx | Updates production telemetry/security copy. |
| src/pages/marketing/platform.tsx | Removes benchmark snapshot section from platform page. |
| src/pages/marketing/home.tsx | Renders capability list via <For> and reactive index accessor. |
| src/pages/marketing/components.tsx | Migrates multiple list renderings to <For>; factors peer list rendering. |
| src/pages/marketing/benchmarks.ts | Removes benchmark snapshot data export (file deleted). |
| src/pages/docs/search.tsx | Refactors search result rendering to nested <Show> branches; adds trigger a11y attrs; updates click handler. |
| src/pages/docs/page.tsx | Refactors doc page rendering with <For> and extracted sections/components. |
| src/pages/docs/package-versions.ts | Updates generated installed package version map. |
| src/pages/docs/lucide-gallery.tsx | Uses <For> for icon list rendering. |
| src/pages/docs/content-overrides.ts | Updates generated/curated docs heading override content. |
| src/pages/docs/cli-snapshot.ts | Updates generated CLI snapshot (version + new command). |
| src/pages/docs/api-page.tsx | Extracts API symbol list to a <For>-based component. |
| src/pages/docs/api-manifest.ts | Updates generated API manifest versions. |
| src/pages/docs/_layout.tsx | Uses <For> for nav + TOC lists; updates nav link close behavior. |
| package.json | Dependency refresh for @askrjs packages + tooling. |
| package-lock.json | Regenerated lockfile reflecting updated dependency graph. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| by={(pkg) => `${pkg.name}:${pkg.importPath ?? ''}`} | ||
| > | ||
| {(pkg) => ( | ||
| <li key={`${pkg.name}:${pkg.importPath}`}> |
Comment on lines
+142
to
+145
| <Show | ||
| when={() => results().length > 0} | ||
| fallback={<p>No results for “{queryValue}”.</p>} | ||
| > |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
TypeScript remains on the latest compatible 6.x line because the website API snapshot generator uses the compiler API removed from TypeScript 7.