fix: stack shared sequences on mobile - #27
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a mobile layout regression where multi-column “shared” grid patterns (sequences and flow maps) were not collapsing to a single column due to selector specificity mismatches against the desktop attribute-based rules.
Changes:
- Increase mobile override specificity by targeting
.sequence[data-columns](instead of.sequence) and forcing a single-columnminmax(0, 1fr)track. - Apply the same specificity correction to
.flow-map__nodes[data-count]for 2/3-node flow maps. - Add CSS regression assertions to ensure both mobile overrides remain present in
src/styles.css.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/docs-catalog.test.ts | Adds regression checks asserting the mobile-specific selectors for .sequence[data-columns] and .flow-map__nodes[data-count] set a single-column grid track. |
| src/styles.css | Updates mobile @media (max-width: 48rem) selectors to match attribute-selector specificity so mobile overrides reliably win over desktop multi-column rules. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation