-
Notifications
You must be signed in to change notification settings - Fork 62
feat: add passkeys support for web #907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NandanPrabhu
wants to merge
8
commits into
main
Choose a base branch
from
feat/web-passkeys
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3d103dc
feat: add passkeys support for web
NandanPrabhu 2012774
fix: guard passkey WebAuthn calls from non-web platform compilation
NandanPrabhu 11fab91
fix: address PR review feedback on web passkeys
NandanPrabhu eee2dc6
fix: correctly decode getTokenByPasskey's token-exchange errors
NandanPrabhu 89614c2
removed example app cahnges for passkeys web example_app.dart reverte…
NandanPrabhu 91c9fff
Resolves PR comments docs improvements and code refactoring
NandanPrabhu eb6a1d0
Fixes unit tests and replace realm with connection everywhere till la…
NandanPrabhu 0e9c334
Updates EXAMPLES.md
NandanPrabhu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one is actually now correct ("no manual serialization needed"), but verify the error-handling table above it (rows mentioning _requestTokenForPasskey / the JSON-string exchange path) no longer describes a path that exists.