fix: let changesets own the version, not a hand edit - #20
Merged
Conversation
I bumped package.json to 1.0.0 by hand AND added a major changeset. This repo publishes through `changesets/action`, which computes the next version from the changesets at merge time - so the two together would have taken 1.0.0 to 2.0.0 and published that, skipping 1.0.0 entirely. package.json goes back to 0.2.0 and the major changeset does the work: `changeset status` confirms one package to be bumped at major, which from 0.2.0 is 1.0.0. The published result is the same version I intended, arrived at by the mechanism the repo actually uses. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catches a wrong version before it publishes. Nothing has shipped yet - npm still shows 0.2.0 - but the open release PR #19 currently proposes 2.0.0.
What happened
In #18 I bumped
package.jsonto 1.0.0 by hand and also added amajorchangeset. This repo publishes throughchangesets/action, which computes the next version from the changesets at merge time. So the two compound:which is what #19 proposes, skipping 1.0.0 entirely.
The fix
package.jsongoes back to0.2.0and the changeset does the work. From 0.2.0, a major bump is 1.0.0 - the version I intended, arrived at by the mechanism the repo actually uses.Once this lands, the changesets action regenerates #19 against the corrected base and it should propose 1.0.0.
Worth noting for review
This is the second time in this sequence that a late push landed on an already-merged branch, so the fix had to be recovered onto a fresh branch. Both #18 and datamaker-py#26 merged fast enough that follow-up commits were orphaned - see datamaker-py#27 for the other recovery.