feat(sap): wire real-SAP E2E into CI via a self-hosted runner - #112
Draft
HappyDevs1 wants to merge 1 commit into
Draft
feat(sap): wire real-SAP E2E into CI via a self-hosted runner#112HappyDevs1 wants to merge 1 commit into
HappyDevs1 wants to merge 1 commit into
Conversation
Repo-work half of #32: a sap-e2e.yml workflow (workflow_dispatch + nightly, runs-on [self-hosted, sap]) that runs cargo test -p flowproof-cli --test sap_e2e with FLOWPROOF_E2E_SAP=1, plus a session- bootstrap script that clears known blocking dialogs (multiple-logon, license info) and ensures SAP Logon is up before/after the run. sap_e2e.rs can now open a connection via SAP_CONNECTION when no session exists (unattended nightly runs), reusing FlowSpec.connection's existing ${VAR} secret resolution - the value never enters the trace or a log. Split out from #107 - the SAP adapter bug fixes found while rehearsing this are in a separate PR (#111), self-contained and not blocked on runner infra. This one stays draft: it needs this machine registered as the [self-hosted, sap] runner and the SAP_CONNECTION secret set before it can actually execute in CI. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repo-work half of #32 (Real-SAP E2E: run
sap_e2eagainst a live SAP system via a self-hosted runner):.github/workflows/sap-e2e.yml:workflow_dispatch+ nightly schedule,runs-on: [self-hosted, sap], runscargo test -p flowproof-cli --test sap_e2ewithFLOWPROOF_E2E_SAP=1. Connection/credentials flow through repo secrets and${VAR}indirection, never entering traces or logs.scripts/sap-session-bootstrap.ps1: run before/after the test on the self-hosted runner — clears the handful of modal dialogs known to block SAP GUI Scripting on an unattended (nightly) run, and starts SAP Logon if it isn't already up.sap_e2e.rs: can now open a connection viaSAP_CONNECTIONwhen no session exists yet, reusingFlowSpec.connection's existing${VAR}resolution — attach-only (today's behavior) stays the default when the var isn't set.Split from #107
The SAP adapter bug fixes found while rehearsing this against a live session are in a separate PR (#111) — self-contained, not blocked on anything. This PR is just the CI/runner infra, which is still genuinely blocked:
Test plan
cargo fmt --all --check— passsap-e2e.ymlactually executing on the[self-hosted, sap]runner — blocked on registering this machine as that runner (repo admin action)SAP_CONNECTIONrepo secret setDraft while the self-hosted runner registration and connection secret are still pending.
🤖 Generated with Claude Code