fix(toolkit-lib): preserve publishing role for import templates#1665
Open
sehyun-hwang wants to merge 1 commit into
Open
fix(toolkit-lib): preserve publishing role for import templates#1665sehyun-hwang wants to merge 1 commit into
sehyun-hwang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cdk importuploads an override templateRoot cause
cdk importcan generate a large CloudFormation override template and publish it as a synthetic file asset. That asset was created with onlybucketNameandobjectKey, so asset publishing used ambient credentials instead of the bootstrap file publishing role. The fix reuses the stack template asset destination metadata from the synthesized asset manifest.Validation
yarn buildinpackages/@aws-cdk/toolkit-libreached the package build path through the root buildyarn buildpassed the@aws-cdk/toolkit-libtests, including the new regression testyarn buildlater failed inaws-cdk.NET init/migrate tests becausedotnetis not installed locallyIssue
n/a
Resolves #1664
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license