feat: LSP hover with resolved CFN properties and template locations#1669
Open
megha-narayanan wants to merge 5 commits into
Open
feat: LSP hover with resolved CFN properties and template locations#1669megha-narayanan wants to merge 5 commits into
megha-narayanan wants to merge 5 commits into
Conversation
…te links Hovering a construct's creation line surfaces its synthesized CloudFormation property values, with each value linking to its location in the template. Adds the cfnProperties attribute to the construct tree, resolveResourceRanges for per-property template ranges, a pure hover content builder, and the onHover server wiring.
megha-narayanan
temporarily deployed
to
automation
GitHub Actions
Inactive
megha-narayanan
requested a deployment
to
integ-approval
GitHub Actions
Waiting
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
aws-cdk-automation
requested a deployment
to
integ-approval
GitHub Actions
Waiting
megha-narayanan
requested a deployment
to
integ-approval
GitHub Actions
Waiting
megha-narayanan
changed the title
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
aws-cdk-automation
requested a deployment
to
integ-approval
GitHub Actions
Waiting
First-letter-upper only capitalized the first character, so properties whose CloudFormation name has an uppercase acronym run (SSESpecification, EnableECSManagedTags, TemplateURL) did not link and rendered as plain text. The L1 camelCase name and the template PascalCase name differ only in letter case, so key both sides lower-cased. Removes pascalCase.
megha-narayanan
requested a deployment
to
integ-approval
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
template-ranges.tswithresolveResourceRanges/indexTemplateRangesto resolve per-property character ranges in a single parsecfnPropertiesfrom the construct tree builder so the hover has access to resolved property valuesexample hover:
Fixes #
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license