Skip to content

feat(toolkit-lib): register message codes for dependency-stack selection lines#1677

Merged
aws-cdk-automation merged 2 commits into
mainfrom
sai/register-dependency-stack-codes
Jun 26, 2026
Merged

feat(toolkit-lib): register message codes for dependency-stack selection lines#1677
aws-cdk-automation merged 2 commits into
mainfrom
sai/register-dependency-stack-codes

Conversation

@sai-ray

@sai-ray sai-ray commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

This PR adds message codes to two stack-selection lines:

  • CDK_TOOLKIT_I1002 — "Including dependency stacks" (upstream)
  • CDK_TOOLKIT_I1002 — "Including depending stacks" (downstream)

They were emitted without a code, so integrators couldn't target them. Text is unchanged.

#1663 will use these codes to suppress the lines for cdk list.

Checklist

  • This change contains a major version upgrade for a dependency and I confirm all breaking changes are addressed
    • Release notes for the new version:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@aws-cdk-automation aws-cdk-automation requested a review from a team June 25, 2026 22:13
@sai-ray

sai-ray commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

This is great! Minor note: the CDK_ASSEMBLY_ messages are reserved for messaged originating from the user's CDK app. This message is from the toolkit, despite being from a class called StackAssembly 🙈

Wasn't totally sure where these belonged, so I followed CDK_TOOLKIT_I1001 and put them in the synth band next to it since it's also a stack-selection message that fires from lots of commands and not just synth.

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Jun 26, 2026
Merged via the queue into main with commit 99902e1 Jun 26, 2026
45 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants