Strip orphaned dark mode fragments#1965
Merged
Merged
Conversation
Remove the @custom-variant dark declaration and 4 incomplete dark: class usages that never rendered correctly without a full dark token set. Dark mode will be implemented in the future using CSS light-dark() on semantic tokens, which won't require per-component dark: classes.
kmcginnes
marked this pull request as ready for review
July 17, 2026 00:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the incomplete dark mode infrastructure that was never functional:
@custom-variant darkdeclaration and its comment block fromindex.cssdark:class usages across Field, DropdownMenu, Checkbox, and CollapsibleSidebar — these never rendered correctly because no full dark token set existsDark mode is an intended future goal. When implemented, it will use CSS
light-dark()on the semantic token definitions, so components won't needdark:classes at all.Validation
pnpm checkspassespnpm testpasses (2178 tests)Related Issues
Check List
pnpm checkspasses with no errors.pnpm testpasses with no failures.