Inline shadcn compatibility tokens#1966
Draft
kmcginnes wants to merge 1 commit into
Draft
Conversation
Replace shadcn compat aliases with canonical tokens in components: - bg-popover / text-popover-foreground → bg-background / text-foreground - text-destructive / bg-destructive → text-danger / bg-danger - bg-accent / text-accent-foreground → bg-primary-subtle / text-primary-foreground Delete the compat alias declarations (destructive, popover, popover-foreground) and the accent alias group from index.css. Update design.md to remove stale dark-mode and compat-token references from the migration banner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Eliminates the shadcn/ui compatibility token layer by rewriting usages in components to canonical tokens and deleting the alias declarations from
index.css.Replacements:
bg-popoverbg-backgroundtext-popover-foregroundtext-foregroundtext-destructive/bg-destructivetext-danger/bg-dangerbg-accentbg-primary-subtletext-accent-foregroundtext-primary-foregroundvar(--color-popover)var(--color-background)var(--color-popover-foreground)var(--color-foreground)Deleted from
@theme:--color-destructive--color-popover/--color-popover-foreground--color-accent/--color-accent-foreground/--color-accent-hoverAlso updates design.md: removes stale dark-mode and compat-token references from the migration banner, removes the accent paragraph.
Validation
pnpm checkspassespnpm testpasses (2178 tests)Related Issues
Check List
pnpm checkspasses with no errors.pnpm testpasses with no failures.