For Feedback only: Feature/webauthn example#1
Draft
GreenBusDriver wants to merge 31 commits into
Draft
Conversation
…ill be broken if not served over https for the EOSIO authenticators that use chain-manifests. We will need to make this hot-swappable prior to release
… more reliably installed. Also fail if they dont install properly
… built contract with version of CDT that includes fixes to *_recover_key wrappers
GreenBusDriver
commented
Sep 23, 2019
GreenBusDriver
commented
Sep 23, 2019
| summary: This is an administrative action that sets the respected "root of trust" key that counter signs 2FA | ||
| icon: https://upload.wikimedia.org/wikipedia/commons/thumb/d/d4/OOjs_UI_icon_key-ltr.svg/200px-OOjs_UI_icon_key-ltr.svg.png#0A1E2435DCAFDF4B34E60C65C570DCE30FAAC1862D7C5E139D188A6EAAF95014 | ||
| --- | ||
| Any usage of bots, macros, or any autonomous form of liking a specific person’s property would result in the investigation of like legitimacy for a post. |
Collaborator
Author
There was a problem hiding this comment.
This statement is repeated verbatim 2x above. Did you intend to modify this for each of these headings? Seems like it might be a copy/pasta thing. All 3 speak of liking instead of renting
Owner
There was a problem hiding this comment.
The ricardians need some work. I'm not brushed up on the ricardian spec which may be why some icons are broken as well.
GreenBusDriver
commented
Sep 23, 2019
|
|
||
| api.post( '/generateRentChallenge', json(), (req, resp) => { | ||
| const name = req.body.accountName | ||
| const propertyName = req.body.propertyName |
Collaborator
Author
There was a problem hiding this comment.
I know this is just an example, but are there regExs we could use to pseudo-sanitize these fields? Maybe a max length and character set, eg. for property [A-Za-z0-9,. ]{100}?
GreenBusDriver
commented
Sep 23, 2019
| // Note there is no verfication of this data as it is out of scope for this demo | ||
| // | ||
| const name = req.body.accountName | ||
| const webauthnPublicKey = req.body.webauthnPublicKey |
Collaborator
Author
There was a problem hiding this comment.
Same here; this should be a very regular string
Locking dependencies and adding check for enrolled state before renting is allowed
Added to README and added UX team's requested tweaks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR created only to allow for comments...