fix: console.error/warn calls in server (59 occurrences) should go through structured logger by 3m1n3nc3 · Pull Request #856 · bakeronchain/learnvault

3m1n3nc3 · 2026-04-26T05:54:56Z

Summary

This PR replaces raw console.error and console.warn usage across the server codebase with the shared structured logger so error reporting goes through a consistent JSON log path.

What changed

added a shared server logger with scoped structured output
sanitized logged Error objects so production logs omit stack traces
migrated server runtime logging from raw console.error and console.warn to the logger
migrated server TypeScript maintenance scripts to the same logger
added tests covering logger sanitization behavior
added an ESLint rule to ban bare console.error in server source and scripts

Why

Raw console calls bypass the server’s structured logging path and make production debugging harder. They also increase the chance of leaking stack traces or inconsistent error payloads. This change centralizes error serialization and makes server-side logging safer and easier to query.

Validation

confirmed there are no remaining raw console.error or console.warn calls under server source or server TS scripts
added focused logger tests for production-safe error sanitization
checked editor diagnostics for touched files

Type of Change

Checklist

Tests added or updated
No hardcoded secrets or private keys
If contract change: cargo test passes
If frontend change: npm run typecheck passes
If backend change: npm test passes
Related issues linked (Closes fix: console.error/warn calls in server (59 occurrences) should go through structured logger #579)
Self-review completed
Code follows project style guidelines

Screenshots (if applicable)

Testing

Added focused coverage for the new logging behavior in server/src/tests/logger.test.ts

Additional Notes

- Add soroban_sdk import to fungible-allowlist to fix missing panic_handler on wasm32 - Regenerate package-lock.json to fix npm ci lock file mismatch - Fix floating promise lint errors in DaoPropose, Dashboard, and server/index.ts - Fix invalid class field syntax in scholarshipTreasury (React hook in class body) - Fix ReactMarkdown className prop removed in v10 (wrap with div) - Run prettier across src/ to fix formatting check failures Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Fix merge conflict in upload.routes.ts (missing JSDoc opening comment). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- Add contractevent to soroban_sdk imports in course_milestone - Remove unresolved learn_token_client re-export from course_milestone - Add AlreadyEnrolled/NotEnrolled/DuplicateSubmission variants to Error enum - Fix export type syntax in src/types/contracts.ts for isolatedModules - Replace mockContractImports with mockContracts in src/test/setup.ts - Add missing DonorStats type import in src/hooks/useDonor.ts - Fix LRNHistoryChart tooltip formatter to accept ValueType | undefined - Fix Dashboard.tsx progressMap -> getCourseProgress Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- Drop non-existent ValueType import; use inferred type in formatter - Clone env before consuming it in upgrade_timelock_vault::is_upgrade_ready Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Contracts: - scholar_nft: replace broken merge-artifact lib.rs with clean upstream version - scholar_nft: rewrite test.rs to match actual API (remove non-existent types) - fungible-allowlist: fix #[contract] placement, drop unused Env import - course_milestone: remove unused constants/params, add ContractPaused error, use correct error variants, add get_milestone_status helper - upgrade_timelock_vault: fix duplicate create_env, BytesN::random, env.register, correct should_panic error strings, fix borrow-after-move - cargo fmt across all contracts Frontend: - LRNHistoryChart: remove non-existent ValueType recharts import - Admin.tsx: fix floating promise errors (void fetchStats/fetchMilestones) - Prettier fixes Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…rnToken hooks

… unit tests - Add verify_milestone() function for admin milestone verification with LRN token minting - Add reject_milestone() function for admin milestone rejection - Add get_milestone_status() function to query milestone states - Create learn_token_client module for LRN token integration - Add comprehensive unit tests covering all functions: - enroll() happy path, duplicate enroll, unknown course scenarios - verify_milestone() happy path, non-admin caller, already verified cases - reject_milestone() happy path, wrong state, non-admin scenarios - get_milestone_status() all state transitions - LRN minting integration tests - Pause functionality tests for all operations - Update error handling with new error variants (NotEnrolled, DuplicateSubmission, InvalidState, ContractPaused) - Fix existing functions to use correct error variants - Update initialize function to store learn token contract address Closes bakeronchain#230

…ge with TTL (Fixes bakeronchain#409)

- Trigger on pull_request targeting main - Run typecheck, lint, vitest, and build steps - Upload dist artifact on success

…pdate tests

…scarded errors from courseImilestore,scholar_nft,fungible_allowlist to allow cargo to build successfully

- Document LRN as soulbound reputation score with supply model - Document GOV as transferable voting token with mint/burn model - Add flywheel diagram showing LRN → GOV → donor → proposal cycle - Honest accounting of V1 centralization and V2 roadmap - Flag GOV burn mechanic as open design question Closes bakeronchain#139

- Poll comments every 15s (configurable via VITE_COMMENT_POLL_MS) - Add "Last updated" timestamp for user feedback - Silent refresh prevents UI flickering during background polls - Clean up interval on unmount to prevent memory leaks - Add localized string for last updated timestamp

Poll comments every 15s (configurable via VITE_COMMENT_POLL_MS) - Add "Last updated" timestamp for user feedback - Silent refresh prevents UI flickering during background polls - Clean up interval on unmount to prevent memory leaks - Add localized string for last updated timestamp closes: bakeronchain#435

- Add server/src/db/migrations/ with 005_governance_and_comments.sql (comments, comment_votes, proposals, scholar_balances) - Fix dollar-quote syntax bug in 003_course_content_schema.sql ($ -> \$\$) - Rewrite scripts/migrate.ts: supports 'up' and 'down' (rollback) commands, typed with PoolClient, tabs formatting to match project style - Strip all CREATE TABLE / DDL from db/index.ts; initDb() now only verifies connection and confirms schema_migrations table exists, exits with clear error if migrations haven't been run - Add migrate and migrate:rollback scripts to server/package.json - Add .github/workflows/server-ci.yml: spins up Postgres 16, runs migrations, then runs jest tests on every push/PR touching server/

- Regenerate package-lock.json to fix missing @noble/hashes@2.0.1 (npm ci failure) - Fix xdr.ScVal.scvU64 call — wrap tokenId with new xdr.Uint64() (TS2345) - Add NftRow type to getScholarCredentials to fix implicit any on row (TS7006) - Add non-null assertion on JWT_SECRET in admin.middleware (TS2769) - Add JWT_SECRET fallback to course-admin.middleware when JWT_PUBLIC_KEY absent - Set process.env.JWT_SECRET in courses-api.test so requireCourseAdmin can verify tokens - Fix upload.test and comments.test — switch from removed uploadRouter/commentsRouter exports to createUploadRouter/createCommentsRouter with inline test JwtService Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…onents

…tion support

feat: add GuessTheNumber component and necessary dependencies

…ployment-workflow Feat/production deployment workflow

…n-calls-in-server-59-occurrences-should-go-through-structured-logger

task done

Anuoluwapo25 · 2026-04-28T14:48:14Z

try force async.... pull from upsteam @3m1n3nc3

…n-calls-in-server-59-occurrences-should-go-through-structured-logger

3m1n3nc3 · 2026-04-28T15:10:22Z

try force async.... pull from upsteam @3m1n3nc3

I've done that

…d lesson versioning

This reverts commit 196719c.

…3-761-762 feat: close bakeronchain#677 bakeronchain#753 bakeronchain#761 bakeronchain#762 with leaderboard E2E, sponsor portal, impact dashboard, and lesson content versioning

…akeronchain#663

…-circuit-breaker feat(stellar): implement circuit breaker for all Stellar RPC calls

Anuoluwapo25 · 2026-04-29T20:54:05Z

i still can't merge and i can't fix from my end...you can ask AI for assistance

feat: complete i18n translations and localization for French language…

…prep feat: prepare smart contracts for formal security audit

…-cache feat: Add Redis RPC cache layer to reduce Stellar RPC calls per page load

…n-calls-in-server-59-occurrences-should-go-through-structured-logger

3m1n3nc3 · 2026-04-30T08:07:28Z

i still can't merge and i can't fix from my end...you can ask AI for assistance

I've resolved the remaining conflicts.

“Ayo-Skiller“ and others added 30 commits March 27, 2026 09:26

chore: merge upstream bakeronchain/learnvault main

39e9d6b

Fix merge conflict in upload.routes.ts (missing JSDoc opening comment). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Merge branch 'main' into main

6c8397b

fix: remove ValueType import from recharts and fix borrow-after-move

58b6c0a

- Drop non-existent ValueType import; use inferred type in formatter - Clone env before consuming it in upgrade_timelock_vault::is_upgrade_ready Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat: Write Vitest unit tests for useDonor, useGovernance, and useLea…

ecab53d

…rnToken hooks

Add Course Management to CourseMilestone Contract

859c744

Make milestone escrow inactivity window configurable

d9f29da

feat: add POST /api/governance/vote endpoint for scholarship proposals

562fa40

Fix storage design: move progress and course data to persistent stora…

1818ad1

…ge with TTL (Fixes bakeronchain#409)

chore: remove NetworkPill workaround

6c55331

fix: repair contract test suite

ba60df4

latest updates

a78b7ea

VoteCast contractevent name renamed to VoteCastEvent

b0aaaa7

ci: add frontend quality checks on PR to main

5837300

- Trigger on pull_request targeting main - Run typecheck, lint, vitest, and build steps - Upload dist artifact on success

fix: openai updated docs

d798f89

milestone_escrow: publish EscrowCreated and EscrowReclaimed events; u…

a834c3f

…pdate tests

fix(update): update cargo.toml to have the repo template metadata, di…

f42c547

…scarded errors from courseImilestore,scholar_nft,fungible_allowlist to allow cargo to build successfully

update

7f01a43

changes

0f7c919

Implement course browsing, lesson viewing, and wallet connection comp…

a1b60d5

…onents

feat: implement DAO proposals page with voting, filtering, and pagina…

7bd2150

…tion support

Github Action on adding donor impact

f032d46

Anuoluwapo25 and others added 8 commits April 28, 2026 10:33

Merge pull request bakeronchain#875 from Airstarr/fix

77d83aa

feat: add GuessTheNumber component and necessary dependencies

fix

d293820

Merge pull request bakeronchain#873 from hally-Ayo/feat/production-de…

d0ff7d0

…ployment-workflow Feat/production deployment workflow

Merge branch 'main' into fix/stellar-rpc-circuit-breaker

83c10b2

Merge remote-tracking branch 'origin/main' into fix/console-error-war…

4409bf8

…n-calls-in-server-59-occurrences-should-go-through-structured-logger

fix conflicts

bac8a54

task done

7b3783e

Merge pull request bakeronchain#877 from LaahAbba/main

9ce2511

task done

Merge remote-tracking branch 'origin/main' into fix/console-error-war…

584a25a

…n-calls-in-server-59-occurrences-should-go-through-structured-logger

iammrjude and others added 10 commits April 28, 2026 17:29

chore: remove tracked target_local build artifacts

6682489

feat: implement leaderboard e2e, sponsor portal, impact dashboard, an…

e32c331

…d lesson versioning

fix: complete leaderboard e2e and lesson content versioning flow

f4c45f3

chore: include remaining local branch updates

196719c

Revert "chore: include remaining local branch updates"

a07e065

This reverts commit 196719c.

fix: resolve repo merge artifacts and stabilize issue branch checks

f21581c

Merge pull request bakeronchain#878 from iammrjude/feat/issues-677-75…

d83b1f9

…3-761-762 feat: close bakeronchain#677 bakeronchain#753 bakeronchain#761 bakeronchain#762 with leaderboard E2E, sponsor portal, impact dashboard, and lesson content versioning

feat: complete i18n translations and localization for French language b…

1df731d

…akeronchain#663

Merge branch 'main' into fix/stellar-rpc-circuit-breaker

9e05f56

Merge pull request bakeronchain#868 from Obiajulu-gif/fix/stellar-rpc…

fd8b69d

…-circuit-breaker feat(stellar): implement circuit breaker for all Stellar RPC calls

Anuoluwapo25 and others added 6 commits April 29, 2026 21:56

Merge pull request bakeronchain#859 from HushLuxe/feat-i18n-french-663

8982c76

feat: complete i18n translations and localization for French language…

Merge branch 'main' into 591-security-audit-prep

b40b17b

Merge pull request bakeronchain#851 from Edoscoba/591-security-audit-…

df109e3

…prep feat: prepare smart contracts for formal security audit

Merge branch 'main' into feat/redis-rpc-cache

1390741

Merge pull request bakeronchain#814 from AlienScroll78/feat/redis-rpc…

bc14e86

…-cache feat: Add Redis RPC cache layer to reduce Stellar RPC calls per page load

Merge remote-tracking branch 'origin/main' into fix/console-error-war…

470df30

…n-calls-in-server-59-occurrences-should-go-through-structured-logger

Anuoluwapo25 force-pushed the main branch from bc14e86 to bf7027e Compare May 26, 2026 09:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: console.error/warn calls in server (59 occurrences) should go through structured logger - #856

fix: console.error/warn calls in server (59 occurrences) should go through structured logger#856
3m1n3nc3 wants to merge 152 commits into
bakeronchain:mainfrom
3m1n3nc3:fix/console-error-warn-calls-in-server-59-occurrences-should-go-through-structured-logger

3m1n3nc3 commented Apr 26, 2026

Uh oh!

Anuoluwapo25 commented Apr 28, 2026

Uh oh!

3m1n3nc3 commented Apr 28, 2026

Uh oh!

Anuoluwapo25 commented Apr 29, 2026

Uh oh!

3m1n3nc3 commented Apr 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

3m1n3nc3 commented Apr 26, 2026

Summary

What changed

Why

Validation

Type of Change

Checklist

Screenshots (if applicable)

Testing

Additional Notes

Uh oh!

Anuoluwapo25 commented Apr 28, 2026

Uh oh!

3m1n3nc3 commented Apr 28, 2026

Uh oh!

Anuoluwapo25 commented Apr 29, 2026

Uh oh!

3m1n3nc3 commented Apr 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants