test(cli): fix session integration test runner#358
Open
Osraka wants to merge 1 commit into
Open
Conversation
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the account-cli session integration test runner so it uses the local Node process with the workspace-resolved
tsxloader instead of invokingnpx tsx.This keeps the test harness aligned with the repo guidance to avoid
npxand prevents the session integration tests from timing out whentsxis not available as a workspace dependency.Details
tsxas a dev dependency for@base-org/account-cliprocess.execPath --import tsxVerification
corepack yarn workspace @base-org/account-cli testcorepack yarn workspace @base-org/account-cli typecheckcorepack yarn workspace @base-org/account-cli buildcorepack yarn exec biome check packages/account-cli/src/commands/session/session.integration.test.ts packages/account-cli/package.json --formatter-enabled=true --linter-enabled=false --organize-imports-enabled=falsecorepack yarn exec biome lint packages/account-cli/src/commands/session/session.integration.test.tsgit diff --checkNote: the workspace-level
account-clilint/format:checkscripts currently fail locally withcommand not found: biome; the equivalent rootyarn exec biome ...checks above pass for the changed files.