Skip to content

Adjustments to updated Blackbird filters#106

Merged
RiabushenkoA merged 1 commit into
mainfrom
develop
Jun 30, 2026
Merged

Adjustments to updated Blackbird filters#106
RiabushenkoA merged 1 commit into
mainfrom
develop

Conversation

@RiabushenkoA

Copy link
Copy Markdown
Contributor

Adjustments to updated Blackbird filters

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e362d849-dbe2-4c45-9988-a8d54c67aab9

📥 Commits

Reviewing files that changed from the base of the PR and between c57986f and a065cb9.

📒 Files selected for processing (2)
  • Apps.DeepL/Actions/TranslationActions.cs
  • Apps.DeepL/Apps.DeepL.csproj

Walkthrough

Updates Blackbird.Filters from 1.1.52 to 1.2.4-beta.1 and bumps the project version. Revises TranslationActions.cs to use Transformation.Load with a native fallback, adds a GetDefaultTagHandling(FileReference) helper, replaces exception-based Serialize() error handling with explicit Target() result checks, and corrects XLIFF1/XLIFF2 media types and filename sources for interoperable output.

Changes

Translation Actions Refactor and Dependency Bump

Layer / File(s) Summary
Dependency bump and namespace updates
Apps.DeepL/Apps.DeepL.csproj, Apps.DeepL/Actions/TranslationActions.cs
Version bumped to 1.2.43, Blackbird.Filters updated to 1.2.4-beta.1, and using directives updated to add Blackbird.Filters.Bilingual.Xliff1 while removing prior content/XLIFF1 usings.
Load-based transformation and tag handling
Apps.DeepL/Actions/TranslationActions.cs
TranslateContent switches from Transformation.Parse to Transformation.Load with immediate fallback to native document translation on failure. GetDefaultTagHandling is introduced to derive tag handling from FileReference content type or filename extension instead of the first batch unit's media types.
Interoperable output serialization fixes
Apps.DeepL/Actions/TranslationActions.cs
original output branch replaces try/catch around Serialize() with explicit content.Target() success/failure handling. xliff1 branch corrected to upload as MediaTypes.Xliff1 with content.BilingualFileName. Default output changed to upload as MediaTypes.Xliff2 using content.ToStream().

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change, updating Blackbird filters and related DeepL translation handling.
Description check ✅ Passed The description is related to the changeset and accurately reflects the Blackbird filter updates.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@RiabushenkoA RiabushenkoA merged commit 45ba3be into main Jun 30, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant