Skip to content

fix download/upload composition processed JSON rich text as simple string#9

Merged
Fesenko-A merged 2 commits into
mainfrom
develop
Jul 13, 2026
Merged

fix download/upload composition processed JSON rich text as simple string#9
Fesenko-A merged 2 commits into
mainfrom
develop

Conversation

@Fesenko-A

Copy link
Copy Markdown
Contributor

Bug fixes for composition rich text handling

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4e4f012a-c1e6-45d2-960a-a9724b74ae00

📥 Commits

Reviewing files that changed from the base of the PR and between 544f2dc and 2e37b17.

📒 Files selected for processing (1)
  • Apps.Uniform/Utils/Converters/CompositionToHtmlConverter.cs

Walkthrough

The change adds rich-text object handling to composition-to-HTML and HTML-to-composition conversion, preserves parsed values as JSON tokens, increments the application version, and removes a duplicate test project file entry.

Changes

Rich-text composition conversion

Layer / File(s) Summary
Rich-text rendering and parsing
Apps.Uniform/Utils/Converters/CompositionToHtmlConverter.cs, Apps.Uniform/Utils/Converters/HtmlToCompositionConverter.cs
Object-valued richText parameters are rendered as HTML, while matching HTML elements are converted back and stored as JToken values at their JSON paths. Empty JSON paths are skipped, and non-rich-text elements retain heading/paragraph parsing.
Project configuration updates
Apps.Uniform/Apps.Uniform.csproj, Tests.Uniform/Tests.Uniform.csproj
The application version changes from 1.0.7 to 1.0.8, and the duplicate appsettings.json output-copy entry is removed.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant CompositionToHtmlConverter
  participant RichTextToHtmlConverter
  participant HtmlToCompositionConverter
  participant HtmlToRichTextConverter
  CompositionToHtmlConverter->>RichTextToHtmlConverter: Convert object parameter to HTML
  HtmlToCompositionConverter->>HtmlToRichTextConverter: Convert rich-text InnerHtml
  HtmlToCompositionConverter->>HtmlToCompositionConverter: Store converted JToken by JSON path
Loading
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: fixing rich text handling for composition download/upload.
Description check ✅ Passed The description matches the repository template and clearly states the bug-fix focus.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Apps.Uniform/Utils/Converters/CompositionToHtmlConverter.cs`:
- Around line 145-157: The rich-text detection criteria must be consistent
across download and upload to preserve round trips. In
Apps.Uniform/Utils/Converters/CompositionToHtmlConverter.cs lines 145-157,
update CreateParameterDiv to require the parameter.Type rich-text criterion
alongside the object value, or document why object detection is authoritative.
In Apps.Uniform/Utils/Converters/HtmlToCompositionConverter.cs lines 70-76,
align the upload detection with that same criterion or validate rich-text
content structure; ensure both converters use matching rules.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5dfe57df-ec70-429e-ac1e-4c8ab6a89050

📥 Commits

Reviewing files that changed from the base of the PR and between ef96f80 and 544f2dc.

📒 Files selected for processing (4)
  • Apps.Uniform/Apps.Uniform.csproj
  • Apps.Uniform/Utils/Converters/CompositionToHtmlConverter.cs
  • Apps.Uniform/Utils/Converters/HtmlToCompositionConverter.cs
  • Tests.Uniform/Tests.Uniform.csproj
💤 Files with no reviewable changes (1)
  • Tests.Uniform/Tests.Uniform.csproj

Comment thread Apps.Uniform/Utils/Converters/CompositionToHtmlConverter.cs
@Fesenko-A
Fesenko-A merged commit 8974103 into main Jul 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant