fix(host): make C# item custom values gob-safe#1
Merged
RestartFU merged 1 commit intoJul 15, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a panic when C# plugins set custom item values that are later encoded by Dragonfly through
encoding/gob.C# item custom values are transported through
ValuesNBT. When those values contain compounds or byte arrays, they may be decoded asmap[string]anyor fixed byte arrays before being passed toitem.Stack.WithValue. Dragonfly later serializes stack values withgob, which requires concrete interface types to be registered and byte arrays to use a gob-safe representation.Changes
gob.[]bytebefore storing them on item stacks.