Skip to content

Update toolchain to Elixir 1.20 final#77

Open
bglusman wants to merge 2 commits into
mainfrom
toolchain-asdf-compatibility
Open

Update toolchain to Elixir 1.20 final#77
bglusman wants to merge 2 commits into
mainfrom
toolchain-asdf-compatibility

Conversation

@bglusman

@bglusman bglusman commented Jun 3, 2026

Copy link
Copy Markdown
Owner

Summary

  • Update mise and asdf toolchain manifests from Elixir 1.20 RC to final 1.20.0 on OTP 29
  • Align CI/release setup-beam config and Tinfoil metadata with final Elixir 1.20.0
  • Update Dune to 0.3.16 and remove the deprecated Phoenix compiler entry from the project compiler list

Verification

  • cd app && MIX_HOME=/tmp/wardwright-mix-otp29 HEX_HOME=/tmp/wardwright-hex-otp29 mise exec -- mix format --check-formatted
  • cd app && MIX_HOME=/tmp/wardwright-mix-otp29 HEX_HOME=/tmp/wardwright-hex-otp29 mise exec -- mix test
  • cd app && MIX_HOME=/tmp/wardwright-mix-otp29 HEX_HOME=/tmp/wardwright-hex-otp29 mise exec -- mix compile --warnings-as-errors
  • git diff --check

Summary by Sourcery

Update the Elixir toolchain and related configuration to target the final Elixir 1.20.0 on OTP 29 and align dependencies and compilers accordingly.

Enhancements:

  • Exclude the deprecated Phoenix compiler from the Mix project compiler list.
  • Bump the Dune dependency to version ~> 0.3.16.

Build:

  • Update mise toolchain configuration to use Elixir 1.20.0-otp-29 instead of the 1.20 RC build.

CI:

  • Update CI and release GitHub Actions workflows to use Elixir 1.20.0 instead of the 1.20.0-rc.6 release candidate and align embedded Elixir version metadata in project configuration.

Copilot AI review requested due to automatic review settings June 3, 2026 20:14
@sourcery-ai

sourcery-ai Bot commented Jun 3, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the Elixir/OTP toolchain from 1.20 RC to the final 1.20.0 release across local dev (mise/asdf), CI, and release workflows, updates the Dune dependency, and adjusts the Mix compiler list to drop the deprecated Phoenix compiler entry.

File-Level Changes

Change Details Files
Standardize Elixir/OTP version on 1.20.0 / OTP 29 across CI and release workflows.
  • Update GitHub Actions setup-beam configuration to use Elixir 1.20.0 instead of 1.20.0-rc.6 for all jobs
  • Keep OTP pinned at 29.0 and Gleam at 1.17.0 while bumping only the Elixir version
.github/workflows/wardwright-release.yml
.github/workflows/ci.yml
Update local toolchain manifests to the final Elixir 1.20.0 on OTP 29.
  • Bump mise Elixir tool entry from 1.20.0-rc.6-otp-29 to 1.20.0-otp-29
  • Align asdf .tool-versions Elixir entry with the final 1.20.0 on OTP 29
mise.toml
.tool-versions
Adjust Mix project configuration for Elixir 1.20 and clean up compiler/dependency setup.
  • Exclude the deprecated :phoenix compiler from Mix.compilers/0 while preserving Gleam compilers prefixing
  • Update Dune dependency from ~> 0.3.15 to ~> 0.3.16
  • Align Tinfoil/CI metadata in mix.exs to report Elixir 1.20.0 instead of the RC
  • Refresh mix.lock to capture the new Dune version and any transitive resolution changes
app/mix.exs
app/mix.lock

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Elixir version to 1.20.0 across .tool-versions, mise.toml, and mix.exs, and upgrades the dune dependency to version 0.3.16. It also modifies the compilers list in mix.exs to subtract :phoenix. Feedback indicates that subtracting :phoenix from Mix.compilers() is redundant as it is not included in the default compilers list, and suggests simplifying the compilers configuration.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread app/mix.exs Outdated

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 2 issues

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="app/mix.exs" line_range="116" />
<code_context>
       version: "0.0.11",
       elixir: "~> 1.18",
-      compilers: [:gleam_deps, :gleam] ++ Mix.compilers(),
+      compilers: [:gleam_deps, :gleam] ++ (Mix.compilers() -- [:phoenix]),
       aliases: ["deps.get": ["deps.get", "gleam.deps.get"]],
       erlc_paths: [
</code_context>
<issue_to_address>
**issue (bug_risk):** Double‑check that removing the :phoenix compiler won’t skip any Phoenix-specific compilation steps you still rely on.

`Mix.compilers() -- [:phoenix]` changes behavior from the default pipeline. If any Phoenix templates/views or other compile-time hooks still rely on the `:phoenix` compiler (e.g. `.eex`/`.heex` compilation), they’ll stop running. Please confirm those responsibilities are either obsolete or handled elsewhere before making this change.
</issue_to_address>

### Comment 2
<location path=".github/workflows/ci.yml" line_range="25" />
<code_context>
         with:
           otp-version: "29.0"
-          elixir-version: "1.20.0-rc.6"
+          elixir-version: "1.20.0"
           gleam-version: "1.17.0"
       - uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
</code_context>
<issue_to_address>
**suggestion:** Consider reducing duplication of Elixir version strings across workflows and config to simplify future bumps.

The Elixir version is duplicated across `ci.yml`, `wardwright-release.yml`, `mise.toml`, and `mix.exs`, increasing the chance of inconsistency on future bumps. Within each workflow, consider centralizing it via a top-level `env:` value or YAML anchor so you only update it in one place per file.

Suggested implementation:

```
          elixir-version: "${{ env.ELIXIR_VERSION }}"

```

```
          elixir-version: "${{ env.ELIXIR_VERSION }}"

```

To fully implement the suggestion and avoid duplication in this workflow, you should also:
1. Add a top-level `env:` block in `.github/workflows/ci.yml` (likely near the top of the file, alongside `name:` and `on:`) defining a single `ELIXIR_VERSION` value, for example:
   ```yaml
   env:
     ELIXIR_VERSION: "1.20.0"
   ```
2. If there are other `elixir-version:` occurrences elsewhere in `ci.yml`, update them to also use `${{ env.ELIXIR_VERSION }}` so there is exactly one Elixir version definition per workflow file.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread app/mix.exs Outdated
Comment thread .github/workflows/ci.yml

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s Elixir toolchain configuration and CI/release workflows to target Elixir 1.20 (moving from an RC to a final version), and adjusts app build configuration accordingly.

Changes:

  • Bump Elixir toolchain references from 1.20.0-rc.6 to 1.20.0 (mise/asdf, CI, release workflow, and tinfoil metadata).
  • Update the app’s Mix configuration to exclude the deprecated Phoenix compiler entry and bump :dune dependency.
  • Update the lockfile to reflect the new :dune version.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
mise.toml Updates mise-managed Elixir toolchain version.
app/mix.exs Adjusts compiler list, tinfoil CI metadata, and bumps :dune requirement.
app/mix.lock Updates locked :dune version/checksums.
.tool-versions Updates asdf-managed Elixir toolchain version.
.github/workflows/ci.yml Aligns CI setup-beam Elixir version to the new target.
.github/workflows/wardwright-release.yml Aligns release workflow setup-beam Elixir version to the new target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants