Add expression interpreter

[ubdbra001]

Here's the initial attempt at adding all the parts of the expression language interpreter.

These successfully cover the full range of tests in the bidsschematools expression tests.
Two things that still need addressing:

• exists passes the tests but needs more work to actually work as described in the schema tools docs
• I'm not sure yet how to integrate them with the Context

[codecov]

Codecov Report

❌ Patch coverage is 20.27027% with 118 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.38%. Comparing base (1963ba3) to head (39d7085).

Additional details and impacted files

@@             Coverage Diff             @@
##             main      #71       +/-   ##
===========================================
- Coverage   90.89%   80.38%   -10.52%     
===========================================
  Files          13       14        +1     
  Lines         846      994      +148     
  Branches      124      175       +51     
===========================================
+ Hits          769      799       +30     
- Misses         47      165      +118     
  Partials       30       30               

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[effigies]

From today's call, here's a quick-and-dirty proxy to allow you to provide multiple namespaces and treat them as one:

class LookupProxy:
    def __init__(self, *objs):
        self.objs = objs

    def __getitem__(self, key):
        for obj in self.objs:
            if isinstance(obj, dict) and key in obj:
                return obj[key]
            if hasattr(obj, key):
                return getattr(obj, key)
        raise AttributeError

    # Provide either attr or item lookup
    __getattr__ = __getitem__

Example usage:

import bids_validator as bv
import bids_validator.context
from bids_validator import expression_language as el
from bids_validator.types.files import FileTree
from bidsschematools.schema import load_schema

schema = load_schema()

root = FileTree.read_from_filesystem('tests/data/bids-examples/ds000117/')
ds = bv.context.Dataset(root, schema)

file = root / 'sub-01' / 'ses-mri' / 'anat' / 'sub-01_ses-mri_acq-mprage_T1w.nii.gz'
context = bv.context.Context(file, ds, None)

namespace = LookupProxy(el.ids, context)

[ubdbra001]

The LookupProxy class suggested works as is, but I had to make a couple of tweaks to the new_evaluator function to get it working with both the expression tests and actual data.
I had a go with parsing and evaluating some rules from the schema, and, of the limited subset I tried, they all produced the correct output.

[ubdbra001]

Needs further work:

• Implement exists properly
• Add tests (improve coverage)
• Add high-level interpret function that creates the proxy, parses the rule, and then evaluates it.

For future work:

• Caching results in expression language
• Return info for reporting failures (similar to how pytest reports e.g. Validation rule abc failed, expected x got y)

[ubdbra001]

Okay, I have created a function for exists that works for everything except "bids-uri".
I vaguely recall that you suggested that it would make most sense as a method for the Context class? Am I remembering correctly?

[effigies]

I think as a method on the context is probably simplest. The alternative would be as a function that takes a context as an argument, and then the proxy setup uses functools.partial to partially apply it. I think that's probably more trouble than it's worth.

[ubdbra001]

Yep that works, and the evaluator can find and use it from the namespace produced by the LookupProxy.

[effigies]

Looking good. A few notes.