fix(head): offset position on new robots received by hightorque#987
Draft
texhnolyze wants to merge 1 commit into
Draft
fix(head): offset position on new robots received by hightorque#987texhnolyze wants to merge 1 commit into
texhnolyze wants to merge 1 commit into
Conversation
which have an offset in the 0° position in comparison to our previous robots. As we have never recalibrated any of the Pi+ motors before and also currently do not have the motor IDs to be able to only reset the head pitch joint we just add a configurable offset on `ROBOT_NAME` basis. If possible the underlying issue should definitely be rectified instead of relying on this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
which have an offset in the 0° position in comparison to our previous
robots. As we have never recalibrated any of the Pi+ motors before
and also currently do not have the motor IDs to be able to only
reset the head pitch joint we just add a configurable offset on
ROBOT_NAMEbasis.If possible the underlying issue should definitely be rectified instead
of relying on this.
Checklist
pixi run build