bip47: Change BIP type, move text from above preamble#2214
Open
murchandamus wants to merge 2 commits into
Open
bip47: Change BIP type, move text from above preamble#2214murchandamus wants to merge 2 commits into
murchandamus wants to merge 2 commits into
Conversation
murchandamus
added
the
Metadata Update
Member
Author
|
cc: @justusranvier to notify author. Justus: if you want, this PR could also drop the Comments-Summary and Comments-URI headers from the preamble which are optional since BIP3 was deployed. Please let me know at your convenience what your preference is. |
murchandamus
added
the
Pending acceptance
Contributor
|
I do not object to removing the Comments-Summary and Comments-URI vandalism. As a historical note the reason the BIP was originally categorized as "information" is because it did not affect the consensus rules of the network and that seemed to be the convention of the time. |
jonatack
removed
the
Pending acceptance
jonatack
reviewed
Jul 23, 2026
|
|
||
| * 2021-02-15: | ||
| ** Finalize specification | ||
| * 2017-09-29: |
Member
There was a problem hiding this comment.
(unless this change was intentional?)
Suggested change
| * 2017-09-29: | |
| * 2017-09-28: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BIP47 describes a scheme that an implementation can be compliant with. Therefore, it should be a Specification BIP. It also has a Changelog above the Preamble which is not compliant with BIP3. This text is moved to the bottom of the document into a new Changelog section instead.