docs(useCanonical): type link array as unhead Link[] (8897318)#294
Merged
Conversation
Syncs upstream nuxt/ui commit 8897318 (#6748). In the docs app's useCanonical
composable, replace the hand-written inline type for the <head> links with the
canonical Link type from @unhead/vue.
- docs/app/composables/useCanonical.ts: import type { Link } from '@unhead/vue'
and change Array<{ rel, href, type? }> to Link[].
Docs-app type-only change. Suite: 5565 passed / 6 skipped.
Ledger: cursor -> 8897318; previous entry 0a1803d reconciled to PR #293.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JS8ypVfQSFzYVZzkTHhURb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs upstream nuxt/ui commit
8897318— docs(useCanonical): type link array as unheadLink[](#6748).b24ui port
docs/app/composables/useCanonical.ts— b24ui's composable carried the identical inline annotation. Addedimport type { Link } from '@unhead/vue'and changedconst links: Array<{ rel: string, href: string, type?: string }>toconst links: Link[], for type consistency withuseHead. (@unhead/vue@2.1.15is present; thecanonical/alternateentries are assignable toLink.)Tests
Docs-app type-only change — no runtime/theme/test/snapshot impact. Suite unchanged: 5565 passed / 6 skipped.
Verify (
CI=true)dev:prepare·lint·typecheck— green locally;test·buildcovered by CI.Ledger: cursor advanced to
8897318(upstream v4 HEAD); previous entry0a1803dreconciled to PR #293.🤖 Generated with Claude Code
Generated by Claude Code