fix(room): mount door fabric at host-agnostic guest path (prx-8uf2)#981
Open
bdelanghe wants to merge 1 commit into
Open
fix(room): mount door fabric at host-agnostic guest path (prx-8uf2)#981bdelanghe wants to merge 1 commit into
bdelanghe wants to merge 1 commit into
Conversation
A live claude-box session (2026-07-03) found the pod's door fabric mounted
at the identical path on both host and guest (${doorDir}:${doorDir}), so
a container could fingerprint the macOS host's username/home layout/OS
purely from its own mountinfo and env vars, even though the doors
themselves are otherwise access-controlled. Add guestDoorDir (default
/run/prx/doors) as the in-container mount target, distinct from the
host-side doorDir; every in-container reference (kube mountPath, Volume=/
--volume destinations, podRoomEnv's projected env, --socket args) now
resolves through it.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Code Coverage OverviewLanguages: TypeScript TypeScript / unitThe overall coverage remains at 88%, unchanged from the branch. Code Coverage is in Public Preview. Learn more and provide us with your feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
guestDoorDir(default/run/prx/doors) toPodSpecas the in-container mount target, distinct from the host-sidedoorDir. Every in-container reference (kubemountPath,Volume=/--volumedestinations,podRoomEnv's projected env,--socketCMD args) now resolves through it; host-side provisioning/polling (renderDoorFabricProvision,waitForSocket, the macOS-hostclient-factory.tsreader) still uses the realdoorDir.Test plan
bun test— 6860 pass, 0 fail (alldoorDir-asserting tests updated to assertguestDoorDirfor in-container paths)bun run typecheck— cleandoorDirplumbing, added one parallel fieldNote: this does not close the finding fully — the virtiofs export-root tell (mountinfo field 4) and daemon log contents need a podman-machine-level virtiofs-tag change, which is out of this repo's scope (tracked separately).
🤖 Generated with Claude Code
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com