Add API to normalise metric for FCI#3424
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
|
|
||
| void Coordinates::normaliseFCI(const BoutReal Bnorm, const BoutReal rho_0) { | ||
| g11 *= SQ(rho_s0); |
There was a problem hiding this comment.
warning: use of undeclared identifier 'rho_s0'; did you mean 'rho_0'? [clang-diagnostic-error]
| g11 *= SQ(rho_s0); | |
| g11 *= SQ(rho_0); |
Additional context
src/mesh/coordinates.cxx:1877: 'rho_0' declared here
void Coordinates::normaliseFCI(const BoutReal Bnorm, const BoutReal rho_0) {
^|
|
||
| void Coordinates::normaliseFCI(const BoutReal Bnorm, const BoutReal rho_0) { | ||
| g11 *= SQ(rho_s0); | ||
| g22 *= SQ(rho_s0); |
There was a problem hiding this comment.
warning: use of undeclared identifier 'rho_s0'; did you mean 'rho_0'? [clang-diagnostic-error]
| g22 *= SQ(rho_s0); | |
| g22 *= SQ(rho_0); |
Additional context
src/mesh/coordinates.cxx:1877: 'rho_0' declared here
void Coordinates::normaliseFCI(const BoutReal Bnorm, const BoutReal rho_0) {
^| void Coordinates::normaliseFCI(const BoutReal Bnorm, const BoutReal rho_0) { | ||
| g11 *= SQ(rho_s0); | ||
| g22 *= SQ(rho_s0); | ||
| g33 *= SQ(rho_s0); |
There was a problem hiding this comment.
warning: use of undeclared identifier 'rho_s0'; did you mean 'rho_0'? [clang-diagnostic-error]
| g33 *= SQ(rho_s0); | |
| g33 *= SQ(rho_0); |
Additional context
src/mesh/coordinates.cxx:1877: 'rho_0' declared here
void Coordinates::normaliseFCI(const BoutReal Bnorm, const BoutReal rho_0) {
^| g11 *= SQ(rho_s0); | ||
| g22 *= SQ(rho_s0); | ||
| g33 *= SQ(rho_s0); | ||
| g12 *= SQ(rho_s0); |
There was a problem hiding this comment.
warning: use of undeclared identifier 'rho_s0'; did you mean 'rho_0'? [clang-diagnostic-error]
| g12 *= SQ(rho_s0); | |
| g12 *= SQ(rho_0); |
Additional context
src/mesh/coordinates.cxx:1877: 'rho_0' declared here
void Coordinates::normaliseFCI(const BoutReal Bnorm, const BoutReal rho_0) {
^| g22 *= SQ(rho_s0); | ||
| g33 *= SQ(rho_s0); | ||
| g12 *= SQ(rho_s0); | ||
| g13 *= SQ(rho_s0); |
There was a problem hiding this comment.
warning: use of undeclared identifier 'rho_s0'; did you mean 'rho_0'? [clang-diagnostic-error]
| g13 *= SQ(rho_s0); | |
| g13 *= SQ(rho_0); |
Additional context
src/mesh/coordinates.cxx:1877: 'rho_0' declared here
void Coordinates::normaliseFCI(const BoutReal Bnorm, const BoutReal rho_0) {
^| g_11 /= SQ(rho_s0); | ||
| g_22 /= SQ(rho_s0); | ||
| g_33 /= SQ(rho_s0); | ||
| g_12 /= SQ(rho_s0); |
There was a problem hiding this comment.
warning: use of undeclared identifier 'rho_s0'; did you mean 'rho_0'? [clang-diagnostic-error]
| g_12 /= SQ(rho_s0); | |
| g_12 /= SQ(rho_0); |
Additional context
src/mesh/coordinates.cxx:1877: 'rho_0' declared here
void Coordinates::normaliseFCI(const BoutReal Bnorm, const BoutReal rho_0) {
^| g_22 /= SQ(rho_s0); | ||
| g_33 /= SQ(rho_s0); | ||
| g_12 /= SQ(rho_s0); | ||
| g_13 /= SQ(rho_s0); |
There was a problem hiding this comment.
warning: use of undeclared identifier 'rho_s0'; did you mean 'rho_0'? [clang-diagnostic-error]
| g_13 /= SQ(rho_s0); | |
| g_13 /= SQ(rho_0); |
Additional context
src/mesh/coordinates.cxx:1877: 'rho_0' declared here
void Coordinates::normaliseFCI(const BoutReal Bnorm, const BoutReal rho_0) {
^| g_33 /= SQ(rho_s0); | ||
| g_12 /= SQ(rho_s0); | ||
| g_13 /= SQ(rho_s0); | ||
| g_23 /= SQ(rho_s0); |
There was a problem hiding this comment.
warning: use of undeclared identifier 'rho_s0'; did you mean 'rho_0'? [clang-diagnostic-error]
| g_23 /= SQ(rho_s0); | |
| g_23 /= SQ(rho_0); |
Additional context
src/mesh/coordinates.cxx:1877: 'rho_0' declared here
void Coordinates::normaliseFCI(const BoutReal Bnorm, const BoutReal rho_0) {
^| if (Bxy.isFci()) { | ||
| g_22_ylow(); | ||
| g_22_yhigh(); | ||
| (*_g_22_ylow) /= SQ(rho_s0); |
There was a problem hiding this comment.
warning: use of undeclared identifier 'rho_s0'; did you mean 'rho_0'? [clang-diagnostic-error]
| (*_g_22_ylow) /= SQ(rho_s0); | |
| (*_g_22_ylow) /= SQ(rho_0); |
Additional context
src/mesh/coordinates.cxx:1877: 'rho_0' declared here
void Coordinates::normaliseFCI(const BoutReal Bnorm, const BoutReal rho_0) {
^| g_22_ylow(); | ||
| g_22_yhigh(); | ||
| (*_g_22_ylow) /= SQ(rho_s0); | ||
| (*_g_22_yhigh) /= SQ(rho_s0); |
There was a problem hiding this comment.
warning: use of undeclared identifier 'rho_s0'; did you mean 'rho_0'? [clang-diagnostic-error]
| (*_g_22_yhigh) /= SQ(rho_s0); | |
| (*_g_22_yhigh) /= SQ(rho_0); |
Additional context
src/mesh/coordinates.cxx:1877: 'rho_0' declared here
void Coordinates::normaliseFCI(const BoutReal Bnorm, const BoutReal rho_0) {
^
|
The coordinates refactor is almost ready which will change how this needs to be implemented, so let's hold off momentarily |
2 participants
Alternative to #3423
It might be nice to do something similar for FA, but I think there are more variants around.